From: Paolo Abeni <pabeni@redhat.com>
To: Slark Xiao <slark_xiao@163.com>,
loic.poulain@oss.qualcomm.com, ryazanov.s.a@gmail.com,
johannes@sipsolutions.net, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
mani@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next v8 3/8] net: wwan: core: split port creation and registration
Date: Thu, 29 Jan 2026 12:46:47 +0100 [thread overview]
Message-ID: <62793715-5fcb-470d-85dd-77472e410df3@redhat.com> (raw)
In-Reply-To: <20260126062158.308598-4-slark_xiao@163.com>
On 1/26/26 7:21 AM, Slark Xiao wrote:
> From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
>
> Upcoming GNSS (NMEA) port type support requires exporting it via the
> GNSS subsystem. On another hand, we still need to do basic WWAN core
> work: find or allocate the WWAN device, make it the port parent, etc. To
> reuse as much code as possible, split the port creation function into
> the registration of a regular WWAN port device, and basic port struct
> initialization.
>
> To be able to use put_device() uniformly, break the device_register()
> call into device_initialize() and device_add() and call device
> initialization earlier.
>
> While at it, fix a minor number leak upon WWAN port registration
> failure.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
The series LGTM, but waiting a bit more for Loic's explicit ack here.
Thanks,
Paolo
next prev parent reply other threads:[~2026-01-29 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 6:21 [net-next v8 0/8] net: wwan: add NMEA port type support Slark Xiao
2026-01-26 6:21 ` [net-next v8 1/8] net: wwan: core: remove unused port_id field Slark Xiao
2026-01-26 6:21 ` [net-next v8 2/8] net: wwan: core: explicit WWAN device reference counting Slark Xiao
2026-01-26 6:21 ` [net-next v8 3/8] net: wwan: core: split port creation and registration Slark Xiao
2026-01-29 11:46 ` Paolo Abeni [this message]
2026-01-26 6:21 ` [net-next v8 4/8] net: wwan: core: split port unregister and stop Slark Xiao
2026-01-26 6:21 ` [net-next v8 5/8] net: wwan: add NMEA port support Slark Xiao
2026-01-26 6:21 ` [net-next v8 6/8] net: wwan: hwsim: refactor to support more port types Slark Xiao
2026-01-26 6:21 ` [net-next v8 7/8] net: wwan: hwsim: support NMEA port emulation Slark Xiao
2026-01-26 6:21 ` [net-next v8 8/8] net: wwan: mhi_wwan_ctrl: Add NMEA channel support Slark Xiao
2026-01-31 2:50 ` [net-next v8 0/8] net: wwan: add NMEA port type support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62793715-5fcb-470d-85dd-77472e410df3@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=slark_xiao@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®