[REGRESSION] nouveau oops on 7.4-rc2

[REGRESSION] nouveau oops on 7.4-rc2

[Ruben Wauters]

[-- Attachment #1: Type: text/plain, Size: 6541 bytes --]

Since 7.4, I have been encountering the following oops when booting my
computer. The issue is present in rc1 and rc2, 7.3 boots fine.
The kernel booted fine and passed to init, which then tried to start
gdm, gdm did not launch, leading me to dig and encounter the following
oops in the journal.

It is worth noting that my laptop, where I encountered this oops, has
two gpus in a hybrid system, one intel integrated, and one nvidia.

It looks to me like something return an -ENOPROTOOPT (likely due to the
hybrid GPU situation) and then another func tried to deference this
without checking for errors.

Some quick digging shows that it could potentially be related to atomic
mode setting being enabled in 7.4, whereas it wasn't before.

I tried to take a look myself at a patch, but unfortunately I got a bit
lost in nouveau, sorry for not being able to fix it, I hope you're able
to. If you need any further information, please don't hesitate to
contact me.

Ruben Wauters

Oops: Oops: 0010 [#1] SMP NOPTI
CPU: 6 UID: 0 PID: 464 Comm: (udev-worker) Not tainted 7.4.0-rc2 #1
PREEMPT(lazy) 
Hardware name: ASUSTeK COMPUTER INC. Vivobook_ASUSLaptop
X3500PCB_K3500PC/X3500PCB, BIOS X3500PCB.305 10/13/2023
RIP: 0010:0x0
Code: Unable to access opcode bytes at 0xffffffffffffffd6.
RSP: 0018:ffffce1000a37668 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff8dff8a97d300 RCX: ffffffffaff4b406
RDX: 0000000000000000 RSI: ffff8dff8a97d300 RDI: ffff8dff86b91000
RBP: ffff8dff86b91000 R08: ffff8dff8a97d300 R09: 0000000000000000
R10: 0000000000000010 R11: 0000000000000000 R12: ffff8dff86b91000
R13: 0000000000000001 R14: ffff8dff86b91000 R15: ffff8dff8299fa00
FS:  00007f9bcede9880(0000) GS:ffff8e0349bd8000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 0000000104854004 CR4: 0000000000f72ef0
PKRU: 55555554
Call Trace:
 <TASK>
 drm_atomic_commit+0xb1/0xe0
 ? __pfx___drm_printfn_info+0x10/0x10
 drm_client_modeset_commit_atomic+0x25c/0x2d0
 drm_client_modeset_commit_locked+0x61/0x180
 ? drm_master_internal_acquire+0x1d/0x40
 drm_client_modeset_commit+0x25/0x40
 drm_fb_helper_single_fb_probe+0x1aa/0x1c0 [drm_client_lib]
 __drm_fb_helper_initial_config_and_unlock+0xa8/0x1b0 [drm_client_lib]
 drm_fbdev_client_hotplug+0x79/0xb0 [drm_client_lib]
 ? drm_client_init+0x116/0x150
 drm_client_register+0x79/0xc0
 drm_fbdev_client_setup+0xc9/0x1e0 [drm_client_lib]
 drm_client_setup+0x6a/0x90 [drm_client_lib]
 nouveau_drm_probe+0x15b/0x1e0 [nouveau]
 local_pci_probe+0x4a/0x90
 ? cpu_hotplug_disable+0x15/0x30
 pci_call_probe+0x5a/0x1a0
 pci_device_probe+0xdb/0x180
 call_driver_probe+0x23/0x100
 ? driver_sysfs_add+0x55/0xc0
 really_probe+0xd7/0x2d0
 ? __pm_runtime_resume+0x50/0x60
 __driver_probe_device+0x9c/0x1b0
 driver_probe_device+0x1f/0x80
 ? __pfx___driver_attach+0x10/0x10
 __driver_attach+0xcc/0x200
 bus_for_each_dev+0x9c/0x100
 ? bus_add_driver+0x84/0x280
 bus_add_driver+0x1d0/0x280
 ? __pfx_init_module+0x10/0x10 [nouveau]
 ? __pfx_init_module+0x10/0x10 [nouveau]
 driver_register+0x75/0xe0
 nouveau_drm_init+0x60/0xff0 [nouveau]
 do_one_initcall+0x89/0x340
 do_init_module+0x8e/0x2b0
 init_module_from_file+0xfe/0x170
 idempotent_init_module+0x23e/0x360
 __x64_sys_finit_module+0x7f/0x110
 do_syscall_64+0xc2/0x4d0
 ? switch_fpu_return+0x5e/0xf0
 ? ksys_pread64+0x61/0xd0
 ? arch_exit_to_user_mode_prepare.isra.0+0x84/0xa0
 ? do_syscall_64+0xff/0x4d0
 ? do_sys_openat2+0x75/0xe0
 ? switch_fpu_return+0x5e/0xf0
 ? arch_exit_to_user_mode_prepare.isra.0+0x84/0xa0
 ? do_syscall_64+0xff/0x4d0
 ? do_syscall_64+0xff/0x4d0
 ? clear_bhb_loop+0x60/0xb0
 ? do_syscall_64+0x37/0x4d0
 entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x7f9bce71f95d
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89
f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01
f0 ff ff 73 01 c3 48 8b 0d 6b 64 0d 00 f7 d8 64 89 01 48
RSP: 002b:00007ffdb99bcab8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
RAX: ffffffffffffffda RBX: 0000564b33e33130 RCX: 00007f9bce71f95d
RDX: 0000000000000000 RSI: 00007f9bced703af RDI: 000000000000004a
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000564b33e30d90
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f9bced703af
R13: 0000000000020000 R14: 0000564b33e2dd30 R15: 0000000000000000
 </TASK>
Modules linked in: drm_gpusvm_helper drm_suballoc_helper snd_hda_intel
snd_sof_pci_intel_tgl snd_sof_pci_intel_cnl snd_sof_intel_hda_generic
soundwire_intel snd_sof_intel_hda_sdw_bpt snd_sof_intel_hda_common
snd_soc_hdac_hda snd_sof_intel_hda_mlink snd_sof_intel_hda
soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof snd_sof_utils
snd_soc_acpi_intel_match vfat snd_soc_acpi_intel_sdca_quirks fat
nouveau(+) soundwire_generic_allocation snd_soc_sdw_utils snd_soc_acpi
crc8 i915 soundwire_bus snd_soc_sdca intel_rapl_msr
intel_uncore_frequency intel_uncore_frequency_common snd_soc_avs
intel_tcc_cooling x86_pkg_temp_thermal intel_powerclamp coretemp
snd_soc_hda_codec mt7921e snd_hda_ext_core mt7921_common snd_hda_codec
kvm_intel mt792x_lib snd_hda_core mt76_connac_lib mt76 snd_intel_dspcfg
snd_intel_sdw_acpi snd_hwdep snd_ctl_led kvm snd_soc_core asus_nb_wmi
mac80211 snd_compress ac97_bus btusb asus_armoury snd_pcm_dmaengine
btmtk irqbypass uvcvideo spi_nor snd_pcm drm_gpuvm btrtl rapl mxm_wmi
btbcm
 intel_cstate mtd uvc drm_ttm_helper firmware_attributes_class iTCO_wdt
drm_buddy btintel videobuf2_vmalloc intel_pmc_bxt
processor_thermal_device_pci_legacy ttm snd_timer mei_pxp >
 fsdev_dax ucsi_acpi typec_ucsi typec hid_multitouch i2c_hid_acpi
i2c_hid video wmi thunderbolt pinctrl_tigerlake intel_oc_wdt vmd
serio_raw rtsx_usb_sdmmc mmc_core rtsx_usb
CR2: 0000000000000000
---[ end trace 0000000000000000 ]---
RIP: 0010:0x0
Code: Unable to access opcode bytes at 0xffffffffffffffd6.
RSP: 0018:ffffce1000a37668 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff8dff8a97d300 RCX: ffffffffaff4b406
RDX: 0000000000000000 RSI: ffff8dff8a97d300 RDI: ffff8dff86b91000
RBP: ffff8dff86b91000 R08: ffff8dff8a97d300 R09: 0000000000000000
R10: 0000000000000010 R11: 0000000000000000 R12: ffff8dff86b91000
R13: 0000000000000001 R14: ffff8dff86b91000 R15: ffff8dff8299fa00
FS:  00007f9bcede9880(0000) GS:ffff8e0349bd8000(0000)
knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 0000000104854004 CR4: 0000000000f72ef0
PKRU: 55555554

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 1028 bytes --]