Re: [PATCH v3 6/8] iio: dac: ds4424: add DS4402/DS4404 device IDs

[David Lechner <dlechner@baylibre.com>]

On 1/28/26 9:38 AM, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Add I2C/OF IDs for DS4402 and DS4404 and set the correct channel count.
> Follow-up changes add per-variant scaling based on external Rfs.
> 
> Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: David Jander <david@protonic.nl>
> ---
> changes v3:
> - Reset author to David Jander and added Co-developed-by tag for
>   Oleksij Rempel to clarify roles
> changes v2:
>   - No changes.
> ---
>  drivers/iio/dac/ds4424.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index c03051dc763e..f340d491fcc1 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -35,6 +35,8 @@
>  }
>  
>  enum ds4424_device_ids {
> +	ID_DS4402,
> +	ID_DS4404,
>  	ID_DS4422,
>  	ID_DS4424,
>  };

I suppose it was already suggested in previous reviews that we should
be dropping these IDs and using device info instead of expanding the
switch statement below.

> @@ -237,6 +239,12 @@ static int ds4424_probe(struct i2c_client *client)
>  		goto fail;
>  
>  	switch (id->driver_data) {
> +	case ID_DS4402:
> +		indio_dev->num_channels = DS4422_MAX_DAC_CHANNELS;
> +		break;
> +	case ID_DS4404:
> +		indio_dev->num_channels = DS4424_MAX_DAC_CHANNELS;
> +		break;
>  	case ID_DS4422:
>  		indio_dev->num_channels = DS4422_MAX_DAC_CHANNELS;
>  		break;
> @@ -278,6 +286,8 @@ static void ds4424_remove(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id ds4424_id[] = {
> +	{ "ds4402", ID_DS4402 },
> +	{ "ds4404", ID_DS4404 },
>  	{ "ds4422", ID_DS4422 },
>  	{ "ds4424", ID_DS4424 },
>  	{ }
> @@ -286,6 +296,8 @@ static const struct i2c_device_id ds4424_id[] = {
>  MODULE_DEVICE_TABLE(i2c, ds4424_id);
>  
>  static const struct of_device_id ds4424_of_match[] = {
> +	{ .compatible = "maxim,ds4402" },
> +	{ .compatible = "maxim,ds4404" },
>  	{ .compatible = "maxim,ds4422" },
>  	{ .compatible = "maxim,ds4424" },
>  	{ }