mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
	linux-kernel@vger.kernel.org, kw@linux.com,
	lpieralisi@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] pci: loongson: Workaround MIPS firmware MRRS settings
Date: Thu, 31 Aug 2023 16:58:32 +0800	[thread overview]
Message-ID: <62a7b292-ea1e-fb88-79cb-e7968d350a5e@flygoat.com> (raw)
In-Reply-To: <CAAhV-H67ehyqtm4ocOTWQPGBioWjQjLoyN5H9hALdq0oXdzWVg@mail.gmail.com>



在 2023/8/31 14:22, Huacai Chen 写道:

[...]
> But it is worth to try, and you can walk the children to set mrrs when
> the quirk runs on bridges, I think.
No, this will break hotplug, I had managed to get hotplug work on 2K1000.
Also we have no guarantee on order of discovering devices.
>> but the old quirk should run on every single device.
> Your current patch has a drawback that both quirks will run for MIPS,
> and their order is random (though it may cause nothing, but not
> elegant).
Actually loongson_mrrs_quirk is declared by DECLARE_PCI_FIXUP_EARLY but
loongson_old_mrrs_quirk is declared by DECLARE_PCI_FIXUP_ENABLE,
which means loongson_old_mrrs_quirk always runs after loongson_mrrs_quirk as
expected.

Thanks
- Jiaxun

[...]

  reply	other threads:[~2023-08-31  8:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25  6:10 Jiaxun Yang
2023-08-06  2:20 ` Jiaxun Yang
2023-08-06 14:30   ` Huacai Chen
2023-08-08  7:38     ` Jiaxun Yang
2023-08-29 12:26       ` Linux regression tracking (Thorsten Leemhuis)
2023-08-31  5:31         ` Jiaxun Yang
2023-08-31  6:22       ` Huacai Chen
2023-08-31  8:58         ` Jiaxun Yang [this message]
2023-08-31  9:42           ` Huacai Chen
2023-08-31 10:04             ` Jiaxun Yang
2023-09-06 16:11               ` Jiaxun Yang
2023-09-07  1:18       ` Manivannan Sadhasivam
2023-09-07  3:13         ` Jiaxun Yang
2023-09-07  5:08           ` Manivannan Sadhasivam
2023-09-20 12:33             ` Linux regression tracking (Thorsten Leemhuis)
2023-10-20 11:04               ` Thorsten Leemhuis
2023-10-22 13:36                 ` Jiaxun Yang
2023-10-22 13:38             ` Jiaxun Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62a7b292-ea1e-fb88-79cb-e7968d350a5e@flygoat.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=bhelgaas@google.com \
    --cc=chenhuacai@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®