mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kevin Tung <kevin.tung.openbmc@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Joel Stanley	 <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Amithash Prasasd	 <amithash@meta.com>,
	Kevin Tung <Kevin.Tung@quantatw.com>,
	Ken Chen	 <Ken.Chen@quantatw.com>,
	Leo Yang <Leo-Yang@quantatw.com>,
	Jackson Liu	 <Jackson.Liu@quantatw.com>
Subject: Re: [PATCH v4 6/7] ARM: dts: aspeed: yosemite5: Add PDB IO expander
Date: Mon, 09 Feb 2026 16:57:48 +1030	[thread overview]
Message-ID: <62b7557d7af89742d142c1c8d317b8fa14f7ba24.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260130-yv5_revise_dts-v4-6-4d924455f3a7@gmail.com>

On Fri, 2026-01-30 at 16:20 +0800, Kevin Tung wrote:
> The new hardware design adds an IO expander on the PDB
> 

What does "PDB" mean? Can you please expand this in the commit message?

>  to support
> fan presence detection and HSC
> 

What does "HSC" mean? Can you please expand this in the commit message?

>  fault monitoring. So Add the PDB
> IO expander device node to the DTS.
> 
> The IO expander interrupt is connected to SGPIO92, which was
> previously named ALERT_PADDLE2_SMB_N and not used by the system.
> This pin is now repurposed and renamed to FM_IOE_ALT_N to reflect
> its function as the PDB IO expander interrupt.
> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-yosemite5.dts    | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 524597a81365ef10cd03b67d35eeb88a965cbe0a..48f864b52d1a22b12f8a39ba9703a90349ed930d 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -389,6 +389,25 @@ adc@1d {
>  		ti,mode = /bits/ 8 <1>;
>  	};
>  
> +	/* PDB IOEXP */
> +	gpio-expander@24 {
> +		compatible = "nxp,pca9555";
> +		reg = <0x24>;
> +		interrupt-parent = <&sgpiom0>;
> +		interrupts = <92 IRQ_TYPE_LEVEL_LOW>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		gpio-line-names =
> +			"FM_P52V_AUX_FLT_N", "FM_P12V_AUX_PWRGD",
> +			"FM_SLOTX_HSC_FAULT_N_FF", "",
> +			"","",
> +			"","",
> +			"PRSNT_FAN0","PRSNT_FAN1",
> +			"PRSNT_FAN2","PRSNT_FAN3",
> +			"","",
> +			"","";
> +	};
> +
>  	power-sensor@40 {
>  		compatible = "ti,ina238";
>  		reg = <0x40>;
> @@ -937,7 +956,7 @@ &sgpiom0 {
>  	"ALERT_OC_PADDLE2_N","",
>  	"ALERT_OC_PWR2_N","",
>  	"ALERT_OC_PWR11_N","",
> -	"ALERT_PADDLE2_SMB_N","",
> +	"FM_IOE_ALT_N","",
>  	"ALERT_PWR14_SB2_LEAK_DETECT_N","",
>  	/*bit48-bit55*/
>  	"ALERT_PWR14_SB3_LEAK_DETECT_N","",

  reply	other threads:[~2026-02-09  6:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  8:20 [PATCH v4 0/7] Revise Meta Yosemite5 devicetree Kevin Tung
2026-01-30  8:20 ` [PATCH v4 1/7] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz Kevin Tung
2026-01-30  8:20 ` [PATCH v4 2/7] ARM: dts: aspeed: yosemite5: Remove ambiguous power monitor DTS nodes Kevin Tung
2026-01-30  8:20 ` [PATCH v4 3/7] ARM: dts: aspeed: yosemite5: Add new SGPIO line names and rename signal Kevin Tung
2026-01-30  8:20 ` [PATCH v4 4/7] ARM: dts: aspeed: yosemite5: Add ipmb node for OCP debug card Kevin Tung
2026-02-09  6:25   ` Andrew Jeffery
2026-02-23 11:32     ` Kevin Tung
2026-01-30  8:20 ` [PATCH v4 5/7] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor Kevin Tung
2026-02-09  6:21   ` Andrew Jeffery
2026-02-23 11:30     ` Kevin Tung
2026-01-30  8:20 ` [PATCH v4 6/7] ARM: dts: aspeed: yosemite5: Add PDB IO expander Kevin Tung
2026-02-09  6:27   ` Andrew Jeffery [this message]
2026-02-23 11:34     ` Kevin Tung
2026-01-30  8:20 ` [PATCH v4 7/7] ARM: dts: aspeed: yosemite5: Add debug card bypass GPIO Kevin Tung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b7557d7af89742d142c1c8d317b8fa14f7ba24.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=Jackson.Liu@quantatw.com \
    --cc=Ken.Chen@quantatw.com \
    --cc=Kevin.Tung@quantatw.com \
    --cc=Leo-Yang@quantatw.com \
    --cc=amithash@meta.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=kevin.tung.openbmc@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®