Re: [PATCH v4 4/7] ARM: dts: aspeed: yosemite5: Add ipmb node for OCP debug card

[Andrew Jeffery <andrew@codeconstruct.com.au>]

On Fri, 2026-01-30 at 16:20 +0800, Kevin Tung wrote:
> Add the device tree node to enable the IPMB interface used by

Here in the patch description you use (capitalised) "IPMB" but in the
patch subject you've used (uncapitalised) "ipmb". Can you please be
consistent and use capitalisation for acronyms.

I wouldn't normally mind and would just fix it up, but I've other
feedback on this series and have fixed the same problem a few patches
already today, so it's a growing source of irritation :)

Andrew

> the OCP debug card.
> 
> Signed-off-by: Kevin Tung <kevin.tung.openbmc@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> index 983aebc394d9159c7e3db2e7c39e963f7b64c855..84d3731b17f7c7c87338672bbcc859de2b89b722 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -365,7 +365,14 @@ i2c6mux0ch3: i2c@3 {
>  
>  /* SCM CPLD I2C */
>  &i2c7 {
> +	multi-master;
>  	status = "okay";
> +
> +	ipmb@10 {
> +		compatible = "ipmb-dev";
> +		reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> +		i2c-protocol;
> +	};
>  };
>  
>  &i2c8 {