[PATCH 0/4] phy: Do not request resets by index

[PATCH 0/4] phy: Do not request resets by index

[Philipp Zabel]

There is no need to request a single reset (or even the first
of multiple resets) by index.

Replace usage of devm/of_reset_control_get(_exclusive)_by_index()
with devm/of_reset_control_get_exclusive() so the _by_index() API,
which is only ever called with index == 0, can be phased out.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Philipp Zabel (4):
      phy: qcom-qusb2: Do not request reset by index
      phy: cadence-torrent: Do not request reset by index
      phy: qcom-qmp-pcie-msm8996: Do not request reset by index
      phy: qualcomm: qcom-m31: Do not request reset by index

 drivers/phy/cadence/phy-cadence-torrent.c        | 2 +-
 drivers/phy/qualcomm/phy-qcom-m31.c              | 2 +-
 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 +-
 drivers/phy/qualcomm/phy-qcom-qusb2.c            | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261106-reset-deindex-phy-503fc3bfe967

Best regards,
--  
Philipp Zabel <p.zabel@pengutronix.de>

[PATCH 1/4] phy: qcom-qusb2: Do not request reset by index

[Philipp Zabel]

There is no need to request a single reset by index.
Use devm_reset_control_get_exclusive() to request the first and only
reset.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 2e5fdb620cb2..6476ed0cb815 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -1032,7 +1032,7 @@ static int qusb2_phy_probe(struct platform_device *pdev)
 	if (IS_ERR(qphy->iface_clk))
 		return PTR_ERR(qphy->iface_clk);
 
-	qphy->phy_reset = devm_reset_control_get_by_index(&pdev->dev, 0);
+	qphy->phy_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
 	if (IS_ERR(qphy->phy_reset)) {
 		dev_err(dev, "failed to get phy core reset\n");
 		return PTR_ERR(qphy->phy_reset);

-- 
2.47.3

[PATCH 2/4] phy: cadence-torrent: Do not request reset by index

[Philipp Zabel]

There is no need to request a single reset by index.
Use devm_reset_control_get_exclusive() to request the first and only
reset.

According to the device tree binding document, the PHY reset should be
specified as first reset, with the name "torrent_reset". All in-tree
device trees specify this correctly, but there may be a backwards
compatibility reason for leaving the name unspecified in the driver.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/phy/cadence/phy-cadence-torrent.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
index d446a0f97688..4a021a0838db 100644
--- a/drivers/phy/cadence/phy-cadence-torrent.c
+++ b/drivers/phy/cadence/phy-cadence-torrent.c
@@ -2790,7 +2790,7 @@ static int cdns_torrent_of_get_reset(struct cdns_torrent_phy *cdns_phy)
 {
 	struct device *dev = cdns_phy->dev;
 
-	cdns_phy->phy_rst = devm_reset_control_get_exclusive_by_index(dev, 0);
+	cdns_phy->phy_rst = devm_reset_control_get_exclusive(dev, NULL);
 	if (IS_ERR(cdns_phy->phy_rst)) {
 		dev_err(dev, "%s: failed to get reset\n",
 			dev->of_node->full_name);

-- 
2.47.3

[PATCH 3/4] phy: qcom-qmp-pcie-msm8996: Do not request reset by index

[Philipp Zabel]

There is no need to request a single reset by index.
Use of_reset_control_get_exclusive() to request the first and only
reset.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
index ed22b7a256ef..7c8ec7e2e5fd 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
@@ -662,7 +662,7 @@ static int qmp_pcie_msm8996_create(struct device *dev, struct device_node *np, i
 				     "failed to get lane%d pipe clock\n", id);
 	}
 
-	qphy->lane_rst = of_reset_control_get_exclusive_by_index(np, 0);
+	qphy->lane_rst = of_reset_control_get_exclusive(np, NULL);
 	if (IS_ERR(qphy->lane_rst)) {
 		dev_err(dev, "failed to get lane%d reset\n", id);
 		return PTR_ERR(qphy->lane_rst);

-- 
2.47.3

[PATCH 4/4] phy: qualcomm: qcom-m31: Do not request reset by index

[Philipp Zabel]

There is no need to request a single reset by index.
Use devm_reset_control_get_exclusive() to request the first and only
reset.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
index 168ea980fda0..b38c3f40b85f 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31.c
@@ -284,7 +284,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
 	if (IS_ERR(qphy->base))
 		return PTR_ERR(qphy->base);
 
-	qphy->reset = devm_reset_control_get_exclusive_by_index(dev, 0);
+	qphy->reset = devm_reset_control_get_exclusive(dev, NULL);
 	if (IS_ERR(qphy->reset))
 		return PTR_ERR(qphy->reset);
 

-- 
2.47.3

Re: [PATCH 1/4] phy: qcom-qusb2: Do not request reset by index

[Konrad Dybcio]

On 11/6/26 4:01 PM, Philipp Zabel wrote:
> There is no need to request a single reset by index.
> Use devm_reset_control_get_exclusive() to request the first and only
> reset.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad