From: "Heiko Stübner" <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Elaine Zhang <zhangqing@rock-chips.com>,
Richard Cochran <richardcochran@gmail.com>,
Cunhao Lu <1579567540@qq.com>
Cc: "shawn.lin" <shawn.lin@rock-chips.com>,
linux-clk <linux-clk@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 2/4] clk: rockchip: Add internal support for 24-bit fractional dividers
Date: Tue, 27 Oct 2026 11:56:01 +0100 [thread overview]
Message-ID: <6321950.31tnzDBltd@diego> (raw)
In-Reply-To: <tencent_AE0E51DA2FACC999E65D6631016044234005@qq.com>
Am Dienstag, 27. Oktober 2026, 11:41:25 Mitteleuropäische Normalzeit schrieb Cunhao Lu:
> > I guess you are describing what you changed against the
> > original patch from Elaine. But this is not how it works.
>
> I'm very sorry for the mistake. After carefully reviewing the guidelines,
> I understand that my notes about changes to Elaine's original patch should
> have been enclosed in square brackets []. I will keep only the significant
> changes in those notes and place them within square brackets.
>
> Thank you again for pointing out my mistake. This reminds me that I still
> have much to learn.
and as I wrote in my reply to Krzysztof slightly, less verbosity is
usually better. I.e. a short description what you did, not a detailed
list is usually nicer, i.e. something like
+++++++++++++
Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
[adapted to mainline rockchip clock and reset handling (xin24m input,
don't introduce CLK_NR_CLKS, etc) ]
Signed-off-by: Cunhao Lu <1579567540@qq.com>
+++++++++++++
And as for speed, maybe give it a bit more time between iterations.
A version per day is a bit fast, as it doesn't give people time to actually
respond.
next prev parent reply other threads:[~2026-10-27 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 10:04 [PATCH v4 0/4] clk: rockchip: Add RK3572 clock and reset support Cunhao Lu via B4 Relay
2026-10-27 10:04 ` [PATCH v4 1/4] dt-bindings: clock: rockchip: Add RK3572 CRU Cunhao Lu via B4 Relay
2026-10-27 18:31 ` Krzysztof Kozlowski
2026-10-27 10:04 ` [PATCH v4 2/4] clk: rockchip: Add internal support for 24-bit fractional dividers Cunhao Lu via B4 Relay
2026-10-27 10:11 ` Shawn Lin
2026-10-27 10:41 ` Cunhao Lu
2026-10-27 10:56 ` Heiko Stübner [this message]
2026-10-27 11:31 ` Cunhao Lu
2026-10-27 10:04 ` [PATCH v4 3/4] clk: rockchip: Add composite clock macro with mux table Cunhao Lu via B4 Relay
2026-10-27 10:04 ` [PATCH v4 4/4] clk: rockchip: Add RK3572 clock and reset support Cunhao Lu via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6321950.31tnzDBltd@diego \
--to=heiko@sntech.de \
--cc=1579567540@qq.com \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®