mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var()
@ 2026-11-01 10:41 Zou Jianqiang
  2026-11-11 14:39 ` Jianqiang Zou
  2026-11-18 19:19 ` Helge Deller
  0 siblings, 2 replies; 3+ messages in thread
From: Zou Jianqiang @ 2026-11-01 10:41 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Helge Deller
  Cc: linux-fbdev, dri-devel, linux-kernel, byu, 25181214217, ONE Zeroiser

From: Jianqiang Zou <jq.zou@outlook.com>

radeonfb_set_par() derives the dot clock from the user supplied
struct fb_var_screeninfo:

	dotClock = 1000000000 / pixClock;

where pixClock is copied from mode->pixclock.  A zero pixclock
bypasses the existing validation and makes the kernel divide by zero
in radeonfb_set_par().

The driver does have a check for this: fb_validate_mode() returns
-EINVAL when pixclock is 0, but radeon_match_mode() only calls it when
the output has no scaler and an EDID-derived mode database is
available:

	if (has_rmx == 0 && rinfo->mon1_modedb)
		if (fb_validate_mode(...))
			return -EINVAL;

mon1_modedb is only filled in when an EDID is read, so when no
EDID-derived mode database is available the validation is skipped and
the invalid mode reaches radeonfb_set_par().

Reject a zero pixclock in radeonfb_check_var() before matching the
mode.  fb_set_var() calls it on the FBIOPUT_VSCREENINFO path before
->fb_set_par(), so the invalid value is rejected before the mode is
applied.  This is the same check other fbdev drivers use (i740fb,
arkfb, s3fb).

Reproduced on Linux 7.3.0 using a custom QEMU PCI stub device with
vendor/device ID 1002:5955; no physical Radeon hardware was used.  A
single FBIOPUT_VSCREENINFO with pixclock = 0 is enough to trigger the
divide error.

Signed-off-by: Jianqiang Zou <jq.zou@outlook.com>
---
 drivers/video/fbdev/aty/radeon_base.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
index b6b058cee..a69e58914 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++ b/drivers/video/fbdev/aty/radeon_base.c
@@ -836,6 +836,9 @@ static int radeonfb_check_var (struct fb_var_screeninfo *var, struct fb_info *in
         int nom, den;
 	unsigned int pitch;
 
+	if (!var->pixclock)
+		return -EINVAL;
+
 	if (radeon_match_mode(rinfo, &v, var))
 		return -EINVAL;
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var()
  2026-11-01 10:41 [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var() Zou Jianqiang
@ 2026-11-11 14:39 ` Jianqiang Zou
  2026-11-18 19:19 ` Helge Deller
  1 sibling, 0 replies; 3+ messages in thread
From: Jianqiang Zou @ 2026-11-11 14:39 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Helge Deller
  Cc: linux-fbdev, dri-devel, linux-kernel, byu, 25181214217

On November 1, 2026 at 18:40, Jianqiang Zou wrote:
> From: Jianqiang Zou <jq.zou@outlook.com>
> 
> radeonfb_set_par() derives the dot clock from the user supplied
> struct fb_var_screeninfo:
> 
> 	dotClock = 1000000000 / pixClock;
> 
> where pixClock is copied from mode->pixclock.  A zero pixclock
> bypasses the existing validation and makes the kernel divide by zero
> in radeonfb_set_par().
> 
> The driver does have a check for this: fb_validate_mode() returns
> -EINVAL when pixclock is 0, but radeon_match_mode() only calls it when
> the output has no scaler and an EDID-derived mode database is
> available:
> 
> 	if (has_rmx == 0 && rinfo->mon1_modedb)
> 		if (fb_validate_mode(...))
> 			return -EINVAL;
> 
> mon1_modedb is only filled in when an EDID is read, so when no
> EDID-derived mode database is available the validation is skipped and
> the invalid mode reaches radeonfb_set_par().
> 
> Reject a zero pixclock in radeonfb_check_var() before matching the
> mode.  fb_set_var() calls it on the FBIOPUT_VSCREENINFO path before
> ->fb_set_par(), so the invalid value is rejected before the mode is
> applied.  This is the same check other fbdev drivers use (i740fb,
> arkfb, s3fb).
> 
> Reproduced on Linux 7.3.0 using a custom QEMU PCI stub device with
> vendor/device ID 1002:5955; no physical Radeon hardware was used.  A
> single FBIOPUT_VSCREENINFO with pixclock = 0 is enough to trigger the
> divide error.
> 
> Signed-off-by: Jianqiang Zou <jq.zou@outlook.com>
> ---
>   drivers/video/fbdev/aty/radeon_base.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index b6b058cee..a69e58914 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -836,6 +836,9 @@ static int radeonfb_check_var (struct fb_var_screeninfo *var, struct fb_info *in
>           int nom, den;
>   	unsigned int pitch;
>   
> +	if (!var->pixclock)
> +		return -EINVAL;
> +
>   	if (radeon_match_mode(rinfo, &v, var))
>   		return -EINVAL;
>   

Hi Benjamin and Helge,

I'm following up on the radeonfb patch I sent on November 1. It rejects 
a zero pixclock in radeonfb_check_var() to prevent a divide-by-zero in 
radeonfb_set_par().

Could you review the patch when you have a chance and apply it if it 
looks good? If any changes or additional testing would help, please let 
me know.

Thanks,
Jianqiang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var()
  2026-11-01 10:41 [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var() Zou Jianqiang
  2026-11-11 14:39 ` Jianqiang Zou
@ 2026-11-18 19:19 ` Helge Deller
  1 sibling, 0 replies; 3+ messages in thread
From: Helge Deller @ 2026-11-18 19:19 UTC (permalink / raw)
  To: Zou Jianqiang, Benjamin Herrenschmidt
  Cc: linux-fbdev, dri-devel, linux-kernel, byu, 25181214217, ONE Zeroiser

On 11/1/26 11:41, Zou Jianqiang wrote:
> From: Jianqiang Zou <jq.zou@outlook.com>
> 
> radeonfb_set_par() derives the dot clock from the user supplied
> struct fb_var_screeninfo:
> 
> 	dotClock = 1000000000 / pixClock;
> 
> where pixClock is copied from mode->pixclock.  A zero pixclock
> bypasses the existing validation and makes the kernel divide by zero
> in radeonfb_set_par().
> 
> The driver does have a check for this: fb_validate_mode() returns
> -EINVAL when pixclock is 0, but radeon_match_mode() only calls it when
> the output has no scaler and an EDID-derived mode database is
> available:
> 
> 	if (has_rmx == 0 && rinfo->mon1_modedb)
> 		if (fb_validate_mode(...))
> 			return -EINVAL;
> 
> mon1_modedb is only filled in when an EDID is read, so when no
> EDID-derived mode database is available the validation is skipped and
> the invalid mode reaches radeonfb_set_par().
> 
> Reject a zero pixclock in radeonfb_check_var() before matching the
> mode.  fb_set_var() calls it on the FBIOPUT_VSCREENINFO path before
> ->fb_set_par(), so the invalid value is rejected before the mode is
> applied.  This is the same check other fbdev drivers use (i740fb,
> arkfb, s3fb).
> 
> Reproduced on Linux 7.3.0 using a custom QEMU PCI stub device with
> vendor/device ID 1002:5955; no physical Radeon hardware was used.  A
> single FBIOPUT_VSCREENINFO with pixclock = 0 is enough to trigger the
> divide error.
> 
> Signed-off-by: Jianqiang Zou <jq.zou@outlook.com>
> ---
>   drivers/video/fbdev/aty/radeon_base.c | 3 +++
>   1 file changed, 3 insertions(+)
applied.

Thanks!
Helge

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18 19:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-01 10:41 [PATCH] fbdev: radeonfb: reject a zero pixclock in radeonfb_check_var() Zou Jianqiang
2026-11-11 14:39 ` Jianqiang Zou
2026-11-18 19:19 ` Helge Deller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®