From: Alexander Sverdlin <alex@sverdlin.org>
To: rajanyadav0307@gmail.com
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Cody Eksal <masterr3c0rd@epochal.quest>
Subject: Re: [PATCH 2/6] cpufreq: sun50i: Move nvmem cell reading into a helper
Date: Tue, 17 Nov 2026 23:34:20 +0100 [thread overview]
Message-ID: <6350ad134c9d09d9754ad79d942a9205c8cdaf84.camel@sverdlin.org> (raw)
In-Reply-To: <20261104-a133-series-v1-2-58217cb33a87@gmail.com>
Hi Rajan,
thank you for the series!
On Wed, 2026-11-04 at 22:40 -0600, Rajan Yadav via B4 Relay wrote:
> From: Rajan Yadav <rajanyadav0307@gmail.com>
>
> The A133 speed grade needs several efuse cells, but the cell reading
> is open coded in sun50i_cpufreq_get_efuse() for a single cell. Move it
> into sun50i_cpufreq_read_cell(), which takes the cell name, so the next
> patch can read the A133 cells by name.
>
> No functional change: the existing users read the first cell, as
> before, with the same length check, byte order and error message. The
> raw bytes are now held in a __le32, the type le32_to_cpu() expects,
> which also removes the sparse warning "cast to restricted __le32" that
> the kernel test robot reported.
>
> Claude Code (Anthropic) drafted this refactor and its message; I
> reviewed and tested it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603021703.aBD0w99y-lkp@intel.com/
> Signed-off-by: Rajan Yadav <rajanyadav0307@gmail.com>
I've tested the series on A133 "marking 0x1400, bin 4, revision 6: speed grade 9":
Vendor build had scaling_max_freq == 1512000.
Upstream before the patch scaling_max_freq == 1464000.
With your series scaling_max_freq == 1512000.
I also tried to set 1008000 and 1512000 and `mhz` tool
reports cpu_MHz=1005.475 and cpu_MHz=1509.625 respectively.
Reviewed-by: Alexander Sverdlin <alex@sverdlin.org>
Tested-by: Alexander Sverdlin <alex@sverdlin.org>
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 55 ++++++++++++++++++++--------------
> 1 file changed, 33 insertions(+), 22 deletions(-)
next prev parent reply other threads:[~2026-11-17 22:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 4:40 [PATCH 0/6] sunxi: A133: Add CPU speed grade detection and OPP table Rajan Yadav via B4 Relay
2026-11-05 4:40 ` [PATCH 1/6] dt-bindings: opp: h6: Add A133 operating points Rajan Yadav via B4 Relay
2026-11-17 22:41 ` Alexander Sverdlin
2026-11-05 4:40 ` [PATCH 2/6] cpufreq: sun50i: Move nvmem cell reading into a helper Rajan Yadav via B4 Relay
2026-11-17 22:34 ` Alexander Sverdlin [this message]
2026-11-05 4:40 ` [PATCH 3/6] cpufreq: sun50i: Add A133 speed grade detection Rajan Yadav via B4 Relay
2026-11-17 22:38 ` Alexander Sverdlin
2026-11-05 4:40 ` [PATCH 4/6] arm64: dts: allwinner: a100: Add A133 speed grade efuse cells Rajan Yadav via B4 Relay
2026-11-17 22:38 ` Alexander Sverdlin
2026-11-05 4:41 ` [PATCH 5/6] arm64: dts: allwinner: a133: Add CPU OPP table Rajan Yadav via B4 Relay
2026-11-17 22:52 ` Alexander Sverdlin
2026-11-05 4:41 ` [PATCH 6/6] arm64: dts: allwinner: a133: Use the A133 " Rajan Yadav via B4 Relay
2026-11-17 22:41 ` Alexander Sverdlin
2026-11-05 11:30 ` [PATCH 0/6] sunxi: A133: Add CPU speed grade detection and " Andre Przywara
2026-11-05 14:49 ` Rajan Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6350ad134c9d09d9754ad79d942a9205c8cdaf84.camel@sverdlin.org \
--to=alex@sverdlin.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=masterr3c0rd@epochal.quest \
--cc=rajanyadav0307@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®