From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
luto@kernel.org, peterz@infradead.org
Cc: ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
thomas.lendacky@amd.com, x86@kernel.org
Subject: Re: [PATCHv3 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page
Date: Thu, 26 May 2022 09:20:56 -0700 [thread overview]
Message-ID: <6350b927-4b3f-6f43-aa62-f8db19fa8d5b@intel.com> (raw)
In-Reply-To: <20220524221012.62332-4-kirill.shutemov@linux.intel.com>
On 5/24/22 15:10, Kirill A. Shutemov wrote:
> + /*
> + * MMIO accesses suppose to be naturally aligned and therefore never
> + * cross a page boundary. Seeing unaligned accesses indicates a bug or
> + * load_unaligned_zeropad() that steps into unmapped shared page.
Wait a sec though...
We've been talking all along about how MMIO accesses are in some cases
just plain old compiler-generated memory accesses. It's *probably* bad
code that does this, but it's not necessarily a bug.
It's kinda like the split lock detection patches. Those definitely
found some stupid stuff, but it wasn't anything that I would have called
an outright bug. Plus, in those cases, folks had explicitly opted in to
more crashes on stupid stuff.
That stupid stuff _might_ be rare enough that it's still OK to just punt
on it and not emulate the instruction (aka. crash). Or, to say that TDX
guests are opting in to being more fragile, just like with split lock
detection.
But, either of those would call for a very different comment.
next prev parent reply other threads:[~2022-05-26 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 22:10 [PATCHv3 0/3] Fix for load_unaligned_zeropad() in TDX guest Kirill A. Shutemov
2022-05-24 22:10 ` [PATCHv3 1/3] x86/tdx: Fix early #VE handling Kirill A. Shutemov
2022-05-24 22:10 ` [PATCHv3 2/3] x86/tdx: Clarify RIP adjustments in #VE handler Kirill A. Shutemov
2022-05-25 16:02 ` Dave Hansen
2022-05-26 20:13 ` Kirill A. Shutemov
2022-05-26 20:18 ` Dave Hansen
2022-05-24 22:10 ` [PATCHv3 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page Kirill A. Shutemov
2022-05-26 16:20 ` Dave Hansen [this message]
2022-05-26 20:36 ` Kirill A. Shutemov
2022-05-26 20:39 ` Dave Hansen
2022-05-26 21:00 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6350b927-4b3f-6f43-aa62-f8db19fa8d5b@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®