From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
luto@kernel.org, peterz@infradead.org, ak@linux.intel.com,
dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
thomas.lendacky@amd.com, x86@kernel.org
Subject: Re: [PATCHv3 2/3] x86/tdx: Clarify RIP adjustments in #VE handler
Date: Thu, 26 May 2022 13:18:23 -0700 [thread overview]
Message-ID: <cc7ee242-31dd-5df5-7685-219b38b6f499@intel.com> (raw)
In-Reply-To: <20220526201354.v5a6fsi4aiuet2d7@black.fi.intel.com>
On 5/26/22 13:13, Kirill A. Shutemov wrote:
>> I'm not super happy with how this comment ended up. First, let's put
>> the comment next to the code to which it applies, like:
>>
>> /*
>> * ve->instr_len is not defined for EPT violations. For those,
>> * the kernel must decode instructions manually and should not
>> * be using this function.
>> */
>> if (WARN_ON_ONCE(ve->exit_reason == EXIT_REASON_EPT_VIOLATION))
>> return 0;
>>
>> /*
>> * Assume that the #VE occurred due to instruction execution.
>> */
>> return ve->instr_len;
> Would it be helpful if the function has a whitelist of exit resons where
> using ve->instr_len is safe? WARN_ONCE() and return 0 otherwise.
Maybe. I was hoping to avoid mostly duplicating the
virt_exception_kernel() switch().
next prev parent reply other threads:[~2022-05-26 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 22:10 [PATCHv3 0/3] Fix for load_unaligned_zeropad() in TDX guest Kirill A. Shutemov
2022-05-24 22:10 ` [PATCHv3 1/3] x86/tdx: Fix early #VE handling Kirill A. Shutemov
2022-05-24 22:10 ` [PATCHv3 2/3] x86/tdx: Clarify RIP adjustments in #VE handler Kirill A. Shutemov
2022-05-25 16:02 ` Dave Hansen
2022-05-26 20:13 ` Kirill A. Shutemov
2022-05-26 20:18 ` Dave Hansen [this message]
2022-05-24 22:10 ` [PATCHv3 3/3] x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page Kirill A. Shutemov
2022-05-26 16:20 ` Dave Hansen
2022-05-26 20:36 ` Kirill A. Shutemov
2022-05-26 20:39 ` Dave Hansen
2022-05-26 21:00 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7ee242-31dd-5df5-7685-219b38b6f499@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®