From: <Valentina.FernandezAlanis@microchip.com>
To: <yuehaibing@huawei.com>, <jassisinghbrar@gmail.com>, <afd@ti.com>,
<Valentina.FernandezAlanis@microchip.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error
Date: Fri, 11 Apr 2025 14:06:35 +0000 [thread overview]
Message-ID: <6369e9e1-aa84-45d9-ad01-28594c280de4@microchip.com> (raw)
In-Reply-To: <20250411075747.3716565-1-yuehaibing@huawei.com>
On 11/04/2025 08:57, Yue Haibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
>
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
> struct sbiret ret;
> ^~~
> CC drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
> ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
> ^~~~~~~~~
>
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
>
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
> ---
> drivers/mailbox/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
>
> config MCHP_SBI_IPC_MBOX
> tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> - depends on RISCV_SBI || COMPILE_TEST
> - depends on ARCH_MICROCHIP
> + depends on RISCV_SBI
> + depends on ARCH_MICROCHIP || COMPILE_TEST
> help
> Mailbox implementation for Microchip devices with an
> Inter-process communication (IPC) controller.
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-04-11 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 7:57 Yue Haibing
2025-04-11 14:06 ` Valentina.FernandezAlanis [this message]
2025-05-14 4:01 ` Yue Haibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6369e9e1-aa84-45d9-ad01-28594c280de4@microchip.com \
--to=valentina.fernandezalanis@microchip.com \
--cc=afd@ti.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®