* [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error
@ 2025-04-11 7:57 Yue Haibing
2025-04-11 14:06 ` Valentina.FernandezAlanis
2025-05-14 4:01 ` Yue Haibing
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2025-04-11 7:57 UTC (permalink / raw)
To: jassisinghbrar, afd, valentina.fernandezalanis; +Cc: linux-kernel, yuehaibing
If COMPILE_TEST is y but RISCV_SBI is n, build fails:
drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
struct sbiret ret;
^~~
CC drivers/nvmem/lpc18xx_otp.o
drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
^~~~~~~~~
move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/mailbox/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index ed52db272f4d..e8445cda7c61 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
config MCHP_SBI_IPC_MBOX
tristate "Microchip Inter-processor Communication (IPC) SBI driver"
- depends on RISCV_SBI || COMPILE_TEST
- depends on ARCH_MICROCHIP
+ depends on RISCV_SBI
+ depends on ARCH_MICROCHIP || COMPILE_TEST
help
Mailbox implementation for Microchip devices with an
Inter-process communication (IPC) controller.
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error
2025-04-11 7:57 [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error Yue Haibing
@ 2025-04-11 14:06 ` Valentina.FernandezAlanis
2025-05-14 4:01 ` Yue Haibing
1 sibling, 0 replies; 3+ messages in thread
From: Valentina.FernandezAlanis @ 2025-04-11 14:06 UTC (permalink / raw)
To: yuehaibing, jassisinghbrar, afd, Valentina.FernandezAlanis; +Cc: linux-kernel
On 11/04/2025 08:57, Yue Haibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
>
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
> struct sbiret ret;
> ^~~
> CC drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
> ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
> ^~~~~~~~~
>
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
>
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
> ---
> drivers/mailbox/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
>
> config MCHP_SBI_IPC_MBOX
> tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> - depends on RISCV_SBI || COMPILE_TEST
> - depends on ARCH_MICROCHIP
> + depends on RISCV_SBI
> + depends on ARCH_MICROCHIP || COMPILE_TEST
> help
> Mailbox implementation for Microchip devices with an
> Inter-process communication (IPC) controller.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error
2025-04-11 7:57 [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error Yue Haibing
2025-04-11 14:06 ` Valentina.FernandezAlanis
@ 2025-05-14 4:01 ` Yue Haibing
1 sibling, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2025-05-14 4:01 UTC (permalink / raw)
To: jassisinghbrar, afd, valentina.fernandezalanis; +Cc: linux-kernel
ping..
On 2025/4/11 15:57, Yue Haibing wrote:
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
>
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
> struct sbiret ret;
> ^~~
> CC drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
> ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
> ^~~~~~~~~
>
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
>
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/mailbox/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
>
> config MCHP_SBI_IPC_MBOX
> tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> - depends on RISCV_SBI || COMPILE_TEST
> - depends on ARCH_MICROCHIP
> + depends on RISCV_SBI
> + depends on ARCH_MICROCHIP || COMPILE_TEST
> help
> Mailbox implementation for Microchip devices with an
> Inter-process communication (IPC) controller.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-14 4:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-11 7:57 [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error Yue Haibing
2025-04-11 14:06 ` Valentina.FernandezAlanis
2025-05-14 4:01 ` Yue Haibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®