* [PATCH] cxl/pci: Show opcode in debug messages when sending a command
@ 2023-01-03 21:01 Robert Richter
2023-01-03 23:22 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Robert Richter @ 2023-01-03 21:01 UTC (permalink / raw)
To: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky, Dan Williams
Cc: Robert Richter, linux-cxl, linux-kernel
For debugging it is very helpful to see which commands are sent. Add
it to the debug message.
Signed-off-by: Robert Richter <rrichter@amd.com>
---
drivers/cxl/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
index 33083a522fd1..316089a393d0 100644
--- a/drivers/cxl/pci.c
+++ b/drivers/cxl/pci.c
@@ -162,7 +162,7 @@ static int __cxl_pci_mbox_send_cmd(struct cxl_dev_state *cxlds,
writeq(cmd_reg, cxlds->regs.mbox + CXLDEV_MBOX_CMD_OFFSET);
/* #4 */
- dev_dbg(dev, "Sending command\n");
+ dev_dbg(dev, "Sending command: 0x%04x\n", mbox_cmd->opcode);
writel(CXLDEV_MBOX_CTRL_DOORBELL,
cxlds->regs.mbox + CXLDEV_MBOX_CTRL_OFFSET);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] cxl/pci: Show opcode in debug messages when sending a command
2023-01-03 21:01 [PATCH] cxl/pci: Show opcode in debug messages when sending a command Robert Richter
@ 2023-01-03 23:22 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2023-01-03 23:22 UTC (permalink / raw)
To: Robert Richter, Alison Schofield, Vishal Verma, Ira Weiny,
Ben Widawsky, Dan Williams
Cc: Robert Richter, linux-cxl, linux-kernel
Robert Richter wrote:
> For debugging it is very helpful to see which commands are sent. Add
> it to the debug message.
Looks good to me, applied for v6.3.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-03 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03 21:01 [PATCH] cxl/pci: Show opcode in debug messages when sending a command Robert Richter
2023-01-03 23:22 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®