mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	ikepanhc@gmail.com,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Armin Wolf" <W_Armin@gmx.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-doc@vger.kernel.org,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	ibm-acpi-devel@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir
Date: Thu, 05 Jun 2025 11:56:51 -0400	[thread overview]
Message-ID: <63e00b35-361f-41ac-8341-f30c2e9dade9@app.fastmail.com> (raw)
In-Reply-To: <d6df0dcf-5786-0ad6-dd30-3a8c9f16426e@linux.intel.com>

Hi Ilpo

On Thu, Jun 5, 2025, at 4:03 AM, Ilpo Järvinen wrote:
> On Wed, 4 Jun 2025, Mark Pearson wrote:
>
>> Create lenovo subdirectory for holding Lenovo specific drivers.
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> ---
>> Changes in v2:
>>  - Rebased to Linus's latest as requested
>>  - Updated documentation reference
>>  - Updated MAINTAINER file
>>  - Removed X86_PLATFORM_DRIVERS_LENOVO as I was worried about
>>    maintaining backwards compatibility for the distros.
>>  - Removed 2nd patch in series splitting out hkeys. That will be for
>>    the future
>
> +# Lenovo x86 Platform-Specific Drivers
> +# Lenovo X86 Platform Specific Drivers
>
> Any possibility to be consistent in formatting that? :-)
>
Ooops - yes. I'll fix.

> Why does the admin guide contain a history book?? It should be guide for 
> this version of kernel, not what was there in 2.6.x era ;-D. Please don't 
> add to that any more, preferrably remove the history part afterwards in a 
> separate change.
>

Sure. Will remove that change from the commit.

I was just trying to make sure I updated in all the right places and realised I hadn't checked the documentation files and found that reference.

> Other than those mentioned above, diffing per vs post seemed clean (I 
> didn't check where the empty lines got added, Andy seemingly did already 
> :-)).
>
Thanks for the review.
Mark

  reply	other threads:[~2025-06-05 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 17:36 Mark Pearson
2025-06-05  5:58 ` Andy Shevchenko
2025-06-05 15:53   ` Mark Pearson
2025-06-05 19:43     ` Andy Shevchenko
2025-06-05 21:03       ` Mark Pearson
2025-06-06  8:22         ` Andy Shevchenko
2025-06-05  8:03 ` Ilpo Järvinen
2025-06-05 15:56   ` Mark Pearson [this message]
2025-06-06 15:58 ` kernel test robot
2025-06-06 17:30   ` Mark Pearson
2025-06-06 18:57     ` Andy Shevchenko
2025-06-06 18:58       ` Andy Shevchenko
2025-06-06 19:30         ` Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63e00b35-361f-41ac-8341-f30c2e9dade9@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=W_Armin@gmx.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®