mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "kernel test robot" <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	ikepanhc@gmail.com,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Armin Wolf" <W_Armin@gmx.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-doc@vger.kernel.org,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	ibm-acpi-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir
Date: Fri, 06 Jun 2025 13:30:25 -0400	[thread overview]
Message-ID: <6d17454f-faac-4616-ac2e-7da80feedf2c@app.fastmail.com> (raw)
In-Reply-To: <202506062319.F0IpDxF6-lkp@intel.com>

Hi,

On Fri, Jun 6, 2025, at 11:58 AM, kernel test robot wrote:
> Hi Mark,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on next-20250606]
> [cannot apply to v6.15]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    
> https://github.com/intel-lab-lkp/linux/commits/Mark-Pearson/platform-x86-Move-Lenovo-files-into-lenovo-subdir/20250605-013934
> base:   linus/master
> patch link:    
> https://lore.kernel.org/r/20250604173702.3025074-1-mpearson-lenovo%40squebb.ca
> patch subject: [PATCH v2] platform/x86: Move Lenovo files into lenovo 
> subdir
> config: x86_64-randconfig-078-20250606 
> (https://download.01.org/0day-ci/archive/20250606/202506062319.F0IpDxF6-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): 
> (https://download.01.org/0day-ci/archive/20250606/202506062319.F0IpDxF6-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new 
> version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: 
> https://lore.kernel.org/oe-kbuild-all/202506062319.F0IpDxF6-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>    drivers/platform/x86/lenovo/think-lmi.c: In function 'certificate_store':
>>> drivers/platform/x86/lenovo/think-lmi.c:661:47: warning: '%s' directive argument is null [-Wformat-overflow=]
>      661 |                 return kasprintf(GFP_KERNEL, "%s,%s", arg1, 
> arg2);
>          |                                               ^~
>    drivers/platform/x86/lenovo/think-lmi.c:657:50: warning: '%s' 
> directive argument is null [-Wformat-overflow=]
>      657 |                 return kasprintf(GFP_KERNEL, "%s,%s,%s",
>          |                                                  ^~
>
>
> vim +661 drivers/platform/x86/lenovo/think-lmi.c
>
> 640a5fa50a42b9 drivers/platform/x86/think-lmi.c Mark Pearson 2021-11-17 
>  652  
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  653  static char *cert_command(struct tlmi_pwd_setting *setting, const 
> char *arg1, const char *arg2)
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  654  {
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  655  	/* Prepend with SVC or SMC if multicert supported */
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  656  	if (tlmi_priv.pwdcfg.core.password_mode >= 
> TLMI_PWDCFG_MODE_MULTICERT)
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  657  		return kasprintf(GFP_KERNEL, "%s,%s,%s",
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  658  				 setting == tlmi_priv.pwd_admin ? "SVC" : "SMC",
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  659  				 arg1, arg2);
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  660  	else
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
> @661  		return kasprintf(GFP_KERNEL, "%s,%s", arg1, arg2);
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  662  }
> 5dcb5ef125907d drivers/platform/x86/think-lmi.c Mark Pearson 2024-10-24 
>  663  
>
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

I'm unable to reproduce this issue with a W=1 build and I think it's a false positive.

Am I safe to ignore this report?

Mark

  reply	other threads:[~2025-06-06 17:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 17:36 Mark Pearson
2025-06-05  5:58 ` Andy Shevchenko
2025-06-05 15:53   ` Mark Pearson
2025-06-05 19:43     ` Andy Shevchenko
2025-06-05 21:03       ` Mark Pearson
2025-06-06  8:22         ` Andy Shevchenko
2025-06-05  8:03 ` Ilpo Järvinen
2025-06-05 15:56   ` Mark Pearson
2025-06-06 15:58 ` kernel test robot
2025-06-06 17:30   ` Mark Pearson [this message]
2025-06-06 18:57     ` Andy Shevchenko
2025-06-06 18:58       ` Andy Shevchenko
2025-06-06 19:30         ` Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d17454f-faac-4616-ac2e-7da80feedf2c@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=W_Armin@gmx.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®