From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <julia.lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Wen Yang <yellowriver2010@hotmail.com>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH v3] coccinelle: semantic patch for missing put_device()
Date: Wed, 13 Feb 2019 16:40:53 +0100 [thread overview]
Message-ID: <63ed130e-7764-3fc6-88b5-5965bf12c790@web.de> (raw)
In-Reply-To: <1550039015-5587-1-git-send-email-wen.yang99@zte.com.cn>
> Reviewed-by: Markus Elfring <Markus.Elfring@web.de>
I have got doubts that my code review comments qualify already
for this tag.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1f947a7a011fcceb14cb912f5481a53b18f1879a#n565
> Cc: cocci@systeme.lip6.fr
I assume that Masahiro Yamada will also need to get explicitly informed
for a possible patch integration.
> v3->v2:
> - reduction of a bit of redundant C code within SmPL search specifications.
> - consider the message construction without using the extra Python variable “msg”
I find it nice that you would like to take this information into account.
> + when != e4 = (T1)platform_get_drvdata(id)
> +(
> +
Should a blank line be omitted at such a source code place?
> + return
> +( id
> +| (T2)dev_get_drvdata(&id->dev)
> +| (T3)platform_get_drvdata(id)
> +);
It seems that you would like to express a different coding style.
Would anybody like to reconsider the position once more for semicolons
in nested disjunctions for such a SmPL search specification?
> +coccilib.report.print_report(p2[0], "ERROR: missing put_device; of_find_device_by_node on line " + p1[0].line + " and return without releasing.")
Your willingness for such a rearrangement is interesting.
How do you think about to move the long message parameter to a subsequent line?
Regards,
Markus
next prev parent reply other threads:[~2019-02-13 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:23 Wen Yang
2019-02-13 15:40 ` Markus Elfring [this message]
2019-02-13 18:29 ` [PATCH v3] Coccinelle: " Markus Elfring
2019-02-13 19:52 ` Julia Lawall
2019-02-14 8:13 ` [v3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ed130e-7764-3fc6-88b5-5965bf12c790@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®