From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Wen Yang <wen.yang99@zte.com.cn>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Wen Yang <yellowriver2010@hotmail.com>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yi Wang <wang.yi59@zte.com.cn>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [v3] Coccinelle: semantic patch for missing put_device()
Date: Thu, 14 Feb 2019 09:13:50 +0100 [thread overview]
Message-ID: <75cad101-727d-2e6b-b6ef-a6a4d0ab4130@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1902132050200.2655@hadrien>
>> + when != ex = \( (T)id \| &id->dev \| get_device(&id->dev) \| (T1)platform_get_drvdata(id) \)
>
> There is no need for the disjunction. There is also no need for the
> different variables.
Really?
Would you like to distinguish the shown assignment expressions anyhow?
> Different variables are only needed when the when conditions are on
> different ...s
I find that this information will need further clarification.
Will any additional adjustments become relevant for such SmPL when specifications?
Regards,
Markus
next prev parent reply other threads:[~2019-02-14 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:23 [PATCH v3] coccinelle: " Wen Yang
2019-02-13 15:40 ` Markus Elfring
2019-02-13 18:29 ` [PATCH v3] Coccinelle: " Markus Elfring
2019-02-13 19:52 ` Julia Lawall
2019-02-14 8:13 ` Markus Elfring [this message]
[not found] <201902141122485708549@zte.com.cn>
2019-02-14 8:15 ` [v3] coccinelle: " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75cad101-727d-2e6b-b6ef-a6a4d0ab4130@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®