From: "Andreas Färber" <afaerber@suse.de>
To: linux-amlogic@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Carlo Caione <carlo@caione.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro
Date: Tue, 17 Jan 2017 04:35:10 +0100 [thread overview]
Message-ID: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> (raw)
In-Reply-To: <20170117030611.23827-2-afaerber@suse.de>
Am 17.01.2017 um 04:06 schrieb Andreas Färber:
> + leds {
> + compatible = "gpio-leds";
> +
> + blue {
> + label = "rbox-pro:blue:on";
> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> +
> + red {
> + label = "rbox-pro:red:standby";
> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + retain-state-suspended;
> + panic-indicator;
> + };
> + };
The original property names for these two were led and red. If anyone
has better label names than the above, please speak up. Ditto for
vega-s95. On the odroidc2 it's called alive but uses heartbeat there.
The vendor device tree had a third "mcu" GPIO in the sysled node,
GPIOAO_6, which leads to immediate power-off. I tried using
"gpio-poweroff" to configure this pin, but that driver fails to
initialize because some pm callback is already registered - I assume
from psci, which apparently succeeds to power-off the system, too. For
comparison, the S905 based Vega S95 Telos has no such mcu property. Any
thoughts?
Also, any ideas how best to switch from blue to red for suspend? Add
pinctrl properties above? systemd service doing echo from userspace? I
assume in Android the Amlogic sysled driver handles all that logic -
didn't find any suspend equivalent to gpio-poweroff.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-01-17 3:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber
2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-17 3:35 ` Andreas Färber [this message]
2017-01-18 22:18 ` Kevin Hilman
2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber
2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber
2017-01-18 9:35 ` Neil Armstrong
2017-01-18 22:38 ` Andreas Färber
2017-01-18 23:38 ` Kevin Hilman
2017-01-21 20:02 ` Rob Herring
2017-01-17 22:54 ` [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string Andreas Färber
2017-01-23 18:21 ` Kevin Hilman
2017-01-23 18:32 ` Andreas Färber
2017-01-21 20:01 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Rob Herring
2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-18 22:27 ` Kevin Hilman
2017-01-19 8:10 ` Neil Armstrong
2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber
2017-01-18 22:29 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de \
--to=afaerber@suse.de \
--cc=carlo@caione.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome