mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zev Weiss <zev@bewilderbeest.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Brown <broonie@kernel.org>,
	Naresh Solanki <naresh.solanki@9elements.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Documentation: ABI: sysfs-driver-regulator-output
Date: Wed, 20 Sep 2023 03:44:29 -0700	[thread overview]
Message-ID: <63fe0803-8120-41a8-8998-a4e6aa32308e@hatter.bewilderbeest.net> (raw)
In-Reply-To: <2023092037-denote-enslave-0a3f@gregkh>

On Wed, Sep 20, 2023 at 02:29:15AM PDT, Greg Kroah-Hartman wrote:
>On Wed, Sep 20, 2023 at 02:02:49AM -0700, Zev Weiss wrote:
>>  static int regulator_userspace_notify(struct notifier_block *nb,
>>  				      unsigned long event,
>>  				      void *ignored)
>>  {
>>  	struct userspace_consumer_data *data =
>>  		container_of(nb, struct userspace_consumer_data, nb);
>> -	static const char * const *envp[] = { "NAME=events", NULL };
>
>You removed this user/kernel api value, what will break if you do that?
>

Sorry, I don't follow -- what removal are you referring to?  The envp 
array still has a NAME entry -- I changed its value from "events" to 
"event", but I wrote that part before I realized that the 'event' 
parameter of the function was actually a bitmask that might convey 
multiple events and just forgot to change it back, so keeping it 
pluralized is probably more appropriate.

And FWIW, I didn't intend for the exact format of the EVENT parameter 
that I sketched there to be something that had to be kept; given that 
there might be multiple entries perhaps it'd be better to use separate 
parameters more like NUMEVENTS, EVENT0, EVENT1, etc?  (Or omit NUMEVENTS 
and just let the consumer count upward until it doesn't find a match.)


Zev


  reply	other threads:[~2023-09-20 10:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 12:14 [PATCH 1/3] regulator: Add uapi header Naresh Solanki
2023-08-31 12:14 ` [PATCH 2/3] regulator: userspace-consumer: Add regulator event support Naresh Solanki
2023-09-01  9:27   ` Zev Weiss
2023-09-01 12:18     ` Mark Brown
2023-08-31 12:14 ` [PATCH 3/3] Documentation: ABI: sysfs-driver-regulator-output Naresh Solanki
2023-09-01  9:13   ` Zev Weiss
2023-09-03 13:04     ` Greg Kroah-Hartman
2023-09-04  0:48       ` Zev Weiss
2023-09-04 12:24         ` Mark Brown
2023-09-10 20:50           ` Zev Weiss
2023-09-12 14:00             ` Mark Brown
2023-09-12 14:03             ` Mark Brown
2023-09-20  9:02               ` Zev Weiss
2023-09-20  9:29                 ` Greg Kroah-Hartman
2023-09-20 10:44                   ` Zev Weiss [this message]
2023-09-20 10:48                     ` Greg Kroah-Hartman
2023-09-20 10:53                       ` Zev Weiss
2023-08-31 12:35 ` [PATCH 1/3] regulator: Add uapi header Mark Brown
2023-08-31 18:34   ` Naresh Solanki
2023-09-01 12:17     ` Mark Brown
2023-08-31 13:50 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63fe0803-8120-41a8-8998-a4e6aa32308e@hatter.bewilderbeest.net \
    --to=zev@bewilderbeest.net \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naresh.solanki@9elements.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®