From: <Tudor.Ambarus@microchip.com>
To: <herbert@gondor.apana.org.au>
Cc: <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <linux-crypto@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] crypto: atmel-tdes - Set the IV after {en,de}crypt
Date: Wed, 27 Nov 2019 16:56:37 +0000 [thread overview]
Message-ID: <642709fe-8cee-4c08-9a4a-05aa47d43c08@microchip.com> (raw)
In-Reply-To: <20191115134854.30190-1-tudor.ambarus@microchip.com>
On 11/15/19 3:49 PM, Tudor Ambarus - M18064 wrote:
> static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
> {
> struct skcipher_request *req = dd->req;
> @@ -580,6 +605,8 @@ static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
>
> dd->flags &= ~TDES_FLAGS_BUSY;
>
> + atmel_tdes_set_iv_as_last_ciphertext_block(dd);
ECB mode does not use an IV, I should probably exclude the update of IV for the
ECB mode. v2 will follow.
> +
> req->base.complete(&req->base, err);
> }
next prev parent reply other threads:[~2019-11-27 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 13:49 Tudor.Ambarus
2019-11-15 13:49 ` [PATCH 2/2] crypto: atmel-aes - Change data type for "lastc" buffer Tudor.Ambarus
2019-11-22 11:09 ` [PATCH 1/2] crypto: atmel-tdes - Set the IV after {en,de}crypt Herbert Xu
2019-11-27 16:56 ` Tudor.Ambarus [this message]
2019-11-28 2:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642709fe-8cee-4c08-9a4a-05aa47d43c08@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®