* [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls
@ 2025-03-12 7:34 Chen Ni
2025-03-14 17:00 ` Jeff Hugo
2025-03-14 17:00 ` Jeff Hugo
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2025-03-12 7:34 UTC (permalink / raw)
To: jeff.hugo, quic_carlv, ogabbay, linux-arm-msm, dri-devel, linux-kernel
Cc: Chen Ni
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/accel/qaic/qaic_debugfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/accel/qaic/qaic_debugfs.c b/drivers/accel/qaic/qaic_debugfs.c
index ba0cf2f94732..a991b8198dc4 100644
--- a/drivers/accel/qaic/qaic_debugfs.c
+++ b/drivers/accel/qaic/qaic_debugfs.c
@@ -240,7 +240,6 @@ static int qaic_bootlog_mhi_probe(struct mhi_device *mhi_dev, const struct mhi_d
mhi_unprepare:
mhi_unprepare_from_transfer(mhi_dev);
destroy_workqueue:
- flush_workqueue(qdev->bootlog_wq);
destroy_workqueue(qdev->bootlog_wq);
out:
return ret;
@@ -253,7 +252,6 @@ static void qaic_bootlog_mhi_remove(struct mhi_device *mhi_dev)
qdev = dev_get_drvdata(&mhi_dev->dev);
mhi_unprepare_from_transfer(qdev->bootlog_ch);
- flush_workqueue(qdev->bootlog_wq);
destroy_workqueue(qdev->bootlog_wq);
qdev->bootlog_ch = NULL;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls
2025-03-12 7:34 [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls Chen Ni
@ 2025-03-14 17:00 ` Jeff Hugo
2025-03-14 17:00 ` Jeff Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Hugo @ 2025-03-14 17:00 UTC (permalink / raw)
To: Chen Ni, quic_carlv, ogabbay, linux-arm-msm, dri-devel, linux-kernel
On 3/12/2025 1:34 AM, Chen Ni wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls
2025-03-12 7:34 [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls Chen Ni
2025-03-14 17:00 ` Jeff Hugo
@ 2025-03-14 17:00 ` Jeff Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Hugo @ 2025-03-14 17:00 UTC (permalink / raw)
To: Chen Ni, quic_carlv, ogabbay, linux-arm-msm, dri-devel, linux-kernel
On 3/12/2025 1:34 AM, Chen Ni wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Pushed to drm-misc-next
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-14 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-12 7:34 [PATCH] accel/qaic: Remove redundant 'flush_workqueue()' calls Chen Ni
2025-03-14 17:00 ` Jeff Hugo
2025-03-14 17:00 ` Jeff Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®