From: Andrew Chew <AChew@nvidia.com>
To: Guenter Roeck <linux@roeck-us.net>,
"wim@iguana.be" <wim@iguana.be>,
"rob@landley.net" <rob@landley.net>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"abrestic@chromium.org" <abrestic@chromium.org>,
"dgreid@chromium.org" <dgreid@chromium.org>,
"katierh@chromium.org" <katierh@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH v4 1/1] watchdog: Add tegra watchdog
Date: Thu, 6 Feb 2014 17:48:08 -0800 [thread overview]
Message-ID: <643E69AA4436674C8F39DCC2C05F76386319985EC6@HQMAIL03.nvidia.com> (raw)
In-Reply-To: <52F438A9.9000908@roeck-us.net>
> On 02/06/2014 02:05 PM, Andrew Chew wrote:
> > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30
> > and later). This driver will configure one watchdog timer that will
> > reset the system in the case of a watchdog timeout.
> >
> > This driver binds to the nvidia,tegra30-timer device node and gets its
> > register base from there.
> >
> > Signed-off-by: Andrew Chew <achew@nvidia.com>
> > ---
>
> Hi Andrew,
>
> > +
> > + /* This is the timer base. */
> > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + if (!res) {
> > + dev_err(&pdev->dev, "incorrect resources\n");
> > + return -ENODEV;
> > + }
> > +
>
> I thought I mentioned that before - dem_iomap_resource() creates the very
> same error message and returns an error if NULL is passed as res argument
> to it. So the above error message (and error check) is really redundant.
Sorry about that. I guess I misunderstood. I'll send a new one out shortly.
prev parent reply other threads:[~2014-02-07 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 22:05 Andrew Chew
2014-02-07 1:36 ` Guenter Roeck
2014-02-07 1:48 ` Andrew Chew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643E69AA4436674C8F39DCC2C05F76386319985EC6@HQMAIL03.nvidia.com \
--to=achew@nvidia.com \
--cc=abrestic@chromium.org \
--cc=dgreid@chromium.org \
--cc=grant.likely@linaro.org \
--cc=katierh@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®