From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>, arm@kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: Convert to using %pOF instead of full_name
Date: Fri, 21 Jul 2017 17:03:01 +0100 [thread overview]
Message-ID: <6445babc-73d3-005c-8b83-22290c5d8bab@arm.com> (raw)
In-Reply-To: <20170718214339.7774-21-robh@kernel.org>
On 18/07/17 22:43, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/firmware/arm_scpi.c | 2 +-
> drivers/firmware/psci.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 8043e51de897..59190c374696 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
>
> count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
> if (count < 0) {
> - dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
> + dev_err(dev, "no mboxes property in '%pOF'\n", np);
> return -ENODEV;
> }
>
(For the SCPI part)
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
I assume you will ask ARM-SoC guys to pick this up. Let us know if you
think otherwise.
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-07-21 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:43 Rob Herring
2017-07-21 16:03 ` Sudeep Holla [this message]
2017-08-16 15:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6445babc-73d3-005c-8b83-22290c5d8bab@arm.com \
--to=sudeep.holla@arm.com \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®