From: Logan Gunthorpe <logang@deltatee.com>
To: Serge Semin <fancer.lancer@gmail.com>,
jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com,
Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com
Cc: Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support
Date: Thu, 30 Nov 2017 15:23:53 -0700 [thread overview]
Message-ID: <644da251-a309-14dc-02b2-cf565b3e3e17@deltatee.com> (raw)
In-Reply-To: <20171130213707.20910-1-fancer.lancer@gmail.com>
On 30/11/17 02:37 PM, Serge Semin wrote:
> Changelog v2:
> - Remove driver Author/Description/License macros
This patch is already very long and should be split up, and you added
more to it? If you want to fix these macros it should be in it's own
patch with it's own justification.
> - u64 db_bits;
> char *buf, cmd;
> - ssize_t rc;
> + ssize_t ret;
I commented on this last time we saw these patches and changing the
variable name from 'rc' to 'ret' (in a number of places) is unnecessary
and just adds to the noise of an already gigantic patch. I'm personally
not going to review it further until I see a cleaner easier to read
patch or series.
Logan
next prev parent reply other threads:[~2017-11-30 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 10:11 [PATCH] " Serge Semin
2017-08-08 18:23 ` Logan Gunthorpe
2017-08-08 18:26 ` Logan Gunthorpe
2017-11-30 21:37 ` [PATCH v2] " Serge Semin
2017-11-30 22:23 ` Logan Gunthorpe [this message]
2017-12-03 9:45 ` kbuild test robot
2017-12-03 9:50 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644da251-a309-14dc-02b2-cf565b3e3e17@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®