* [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros
@ 2026-04-13 23:58 Jeff Johnson
2026-10-08 17:30 ` Rameshkumar Sundaram
2026-10-09 1:49 ` Baochen Qiang
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2026-04-13 23:58 UTC (permalink / raw)
To: Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel, Jeff Johnson
Many of the HAL_RX_REO_QUEUE_INFO macros are unused, so remove them.
No functional change. Compile Tested only.
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
This issue was highlighted by AI review which noted that the
HAL_RX_REO_QUEUE_INFO2_MSDU_COUNT macro was missing GENMASK().
However, rather than fix an unused macro, it seems "better" to just
remove it (along with all other unused HAL_RX_REO_QUEUE_INFO macros).
---
drivers/net/wireless/ath/ath12k/wifi7/hal_desc.h | 26 ------------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_desc.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_desc.h
index e1ab47b44433..822de3a4abc8 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal_desc.h
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_desc.h
@@ -2100,41 +2100,15 @@ enum hal_rx_reo_queue_pn_size {
#define HAL_RX_REO_QUEUE_INFO0_VLD BIT(0)
#define HAL_RX_REO_QUEUE_INFO0_ASSOC_LNK_DESC_COUNTER GENMASK(2, 1)
-#define HAL_RX_REO_QUEUE_INFO0_DIS_DUP_DETECTION BIT(3)
-#define HAL_RX_REO_QUEUE_INFO0_SOFT_REORDER_EN BIT(4)
#define HAL_RX_REO_QUEUE_INFO0_AC GENMASK(6, 5)
-#define HAL_RX_REO_QUEUE_INFO0_BAR BIT(7)
#define HAL_RX_REO_QUEUE_INFO0_RETRY BIT(8)
-#define HAL_RX_REO_QUEUE_INFO0_CHECK_2K_MODE BIT(9)
-#define HAL_RX_REO_QUEUE_INFO0_OOR_MODE BIT(10)
#define HAL_RX_REO_QUEUE_INFO0_BA_WINDOW_SIZE GENMASK(20, 11)
#define HAL_RX_REO_QUEUE_INFO0_PN_CHECK BIT(21)
-#define HAL_RX_REO_QUEUE_INFO0_EVEN_PN BIT(22)
-#define HAL_RX_REO_QUEUE_INFO0_UNEVEN_PN BIT(23)
-#define HAL_RX_REO_QUEUE_INFO0_PN_HANDLE_ENABLE BIT(24)
#define HAL_RX_REO_QUEUE_INFO0_PN_SIZE GENMASK(26, 25)
#define HAL_RX_REO_QUEUE_INFO0_IGNORE_AMPDU_FLG BIT(27)
#define HAL_RX_REO_QUEUE_INFO1_SVLD BIT(0)
#define HAL_RX_REO_QUEUE_INFO1_SSN GENMASK(12, 1)
-#define HAL_RX_REO_QUEUE_INFO1_CURRENT_IDX GENMASK(22, 13)
-#define HAL_RX_REO_QUEUE_INFO1_SEQ_2K_ERR BIT(23)
-#define HAL_RX_REO_QUEUE_INFO1_PN_ERR BIT(24)
-#define HAL_RX_REO_QUEUE_INFO1_PN_VALID BIT(31)
-
-#define HAL_RX_REO_QUEUE_INFO2_MPDU_COUNT GENMASK(6, 0)
-#define HAL_RX_REO_QUEUE_INFO2_MSDU_COUNT (31, 7)
-
-#define HAL_RX_REO_QUEUE_INFO3_TIMEOUT_COUNT GENMASK(9, 4)
-#define HAL_RX_REO_QUEUE_INFO3_FWD_DUE_TO_BAR_CNT GENMASK(15, 10)
-#define HAL_RX_REO_QUEUE_INFO3_DUPLICATE_COUNT GENMASK(31, 16)
-
-#define HAL_RX_REO_QUEUE_INFO4_FRAME_IN_ORD_COUNT GENMASK(23, 0)
-#define HAL_RX_REO_QUEUE_INFO4_BAR_RECVD_COUNT GENMASK(31, 24)
-
-#define HAL_RX_REO_QUEUE_INFO5_LATE_RX_MPDU_COUNT GENMASK(11, 0)
-#define HAL_RX_REO_QUEUE_INFO5_WINDOW_JUMP_2K GENMASK(15, 12)
-#define HAL_RX_REO_QUEUE_INFO5_HOLE_COUNT GENMASK(31, 16)
struct hal_rx_reo_queue {
struct hal_desc_header desc_hdr;
---
base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c
change-id: 20260404-hal_rx_reo_queue_info2_msdu_count-0e2eb6da0461
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros
2026-04-13 23:58 [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros Jeff Johnson
@ 2026-10-08 17:30 ` Rameshkumar Sundaram
2026-10-09 1:49 ` Baochen Qiang
1 sibling, 0 replies; 3+ messages in thread
From: Rameshkumar Sundaram @ 2026-10-08 17:30 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel
On 4/14/2026 5:28 AM, Jeff Johnson wrote:
> Many of the HAL_RX_REO_QUEUE_INFO macros are unused, so remove them.
>
> No functional change. Compile Tested only.
>
> Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros
2026-04-13 23:58 [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros Jeff Johnson
2026-10-08 17:30 ` Rameshkumar Sundaram
@ 2026-10-09 1:49 ` Baochen Qiang
1 sibling, 0 replies; 3+ messages in thread
From: Baochen Qiang @ 2026-10-09 1:49 UTC (permalink / raw)
To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel
On 4/14/2026 7:58 AM, Jeff Johnson wrote:
> Many of the HAL_RX_REO_QUEUE_INFO macros are unused, so remove them.
>
> No functional change. Compile Tested only.
>
> Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-09 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-13 23:58 [PATCH ath-next] wifi: ath12k: Remove unused HAL_RX_REO_QUEUE_INFO macros Jeff Johnson
2026-10-08 17:30 ` Rameshkumar Sundaram
2026-10-09 1:49 ` Baochen Qiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®