mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>, akpm@linux-foundation.org
Cc: ljs@kernel.org, liam@infradead.org, vbabka@kernel.org,
	rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	qi.zheng@linux.dev, jack@suse.cz, pfalcato@suse.de,
	ayushr@modal.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: memory: fix truncation removing mapped folios
Date: Wed, 21 Oct 2026 15:46:05 +0800	[thread overview]
Message-ID: <6462de1a-b141-4f20-94a8-973708a71ba2@linux.alibaba.com> (raw)
In-Reply-To: <938e215b-a2fd-4f1a-b4c5-e46b8af0f00b@kernel.org>



On 10/20/26 4:36 PM, David Hildenbrand (Arm) wrote:
>>>>                   if (pmd_none(*pmd)) {
>>>> +                       if (details && details->single_folio)
>>>> +                               sync_with_folio_pmd_zap(tlb->mm, pmd);
>>>>                           addr = next;
>>>>                           continue;
>>>>                   }
>>>
>>> We do have another sync_with_folio_pmd_zap() user in page_vma_mapped_walk(),
>>> does that one need care as well?
>>
>> Good point. But I don't want to add page_vma_mapped_walk() changes into this fix
>> patch. I need to analyze all callers of page_vma_mapped_walk() and the potential
>> races. I'll look into whether it should be changed in a follow-up patch.
> 
> Yes, please have a look. I am 99.9% sure that we face the exact same issue there
> as well.

Sure. Add it to my TODO list.

BTW, could you take a look at my reply to your concern about v3 when you 
feel free? Thanks.

https://lore.kernel.org/all/179c26ed-1764-4e5b-a7ee-047ddabbfea1@linux.alibaba.com/

  reply	other threads:[~2026-10-21  7:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10  7:22 Baolin Wang
2026-10-12 10:23 ` David Hildenbrand (Arm)
2026-10-13  9:36   ` Baolin Wang
2026-10-14 13:25     ` David Hildenbrand (Arm)
2026-10-14 14:05       ` Pedro Falcato
2026-10-14 18:44         ` David Hildenbrand (Arm)
2026-10-15  6:41       ` Baolin Wang
2026-10-15 19:00         ` David Hildenbrand (Arm)
2026-10-16  1:47           ` Baolin Wang
2026-10-20  8:36             ` David Hildenbrand (Arm)
2026-10-21  7:46               ` Baolin Wang [this message]
2026-10-13 10:24 ` Pedro Falcato
2026-10-14  9:51   ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6462de1a-b141-4f20-94a8-973708a71ba2@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=ayushr@modal.com \
    --cc=david@kernel.org \
    --cc=jack@suse.cz \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pfalcato@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®