From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Naushir Patuck <naush@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4 3/4] media: raspberrypi: Add support for RP1-CFE
Date: Tue, 10 Sep 2024 13:26:39 +0300 [thread overview]
Message-ID: <6477da61-4e7f-418c-b586-39c7b34066f8@ideasonboard.com> (raw)
In-Reply-To: <20240910101137.GD6996@pendragon.ideasonboard.com>
Hi,
On 10/09/2024 13:11, Laurent Pinchart wrote:
> On Tue, Sep 10, 2024 at 12:56:38PM +0300, Tomi Valkeinen wrote:
>> On 10/09/2024 12:19, Jacopo Mondi wrote:
>>
>>> However, I think this current patch is correct (assuming the above
>>> reasoning on i2c sensor drivers is correct) and doesn't require
>>> CONFIG_PM, so I would be tempted to keep this version.
>>
>> I think the existence of this discussion alone proves my point that we
>> should only support PM-case, unless !PM is a requirement =).
>
> For me it proves there's a dire need to document the runtime PM API in a
> way that a human could understand :-)
That too, but it's a parallel track =).
>> But if you do want to keep !PM:
>>
>> Is there a reason why not mark the device as active with
>> pm_runtime_set_active() after calling pispbe_runtime_resume and before
>> accessing the device? That feels like the most logical way to use the
>> function, and it would be right regardless whether the core will enable
>> the parents before probe() or not.
>
> Does pm_runtime_set_active() resume the parent ?
I thought so, but I'm not sure anymore:
> if the device has a parent and the parent is not active, and the
> parent's power.ignore_children flag is unset, the device's status
> cannot be set to RPM_ACTIVE, so -EBUSY is returned in that case.
It does resume the suppliers, though.
So using pm_runtime_set_active() only works if you know that the parent
has been activated earlier? If there's such a guarantee for probe() and
remove(), does it then mean that you can only call
pm_runtime_set_active() in probe()/remove()...
Tomi
next prev parent reply other threads:[~2024-09-10 10:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:19 [PATCH v4 0/4] media: raspberrypi: Support RPi5's CFE Tomi Valkeinen
2024-09-04 11:19 ` [PATCH v4 1/4] media: uapi: Add meta formats for PiSP FE config and stats Tomi Valkeinen
2024-09-04 11:19 ` [PATCH v4 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe Tomi Valkeinen
2024-09-04 11:19 ` [PATCH v4 3/4] media: raspberrypi: Add support for RP1-CFE Tomi Valkeinen
2024-09-05 10:50 ` kernel test robot
2024-09-05 11:11 ` Laurent Pinchart
2024-09-09 5:08 ` Tomi Valkeinen
2024-09-09 5:22 ` Tomi Valkeinen
2024-09-09 9:13 ` Jacopo Mondi
2024-09-09 10:04 ` Tomi Valkeinen
2024-09-09 13:29 ` Jacopo Mondi
2024-09-09 13:45 ` Laurent Pinchart
2024-09-09 15:52 ` Sakari Ailus
2024-09-10 9:19 ` Jacopo Mondi
2024-09-10 9:25 ` Sakari Ailus
2024-09-10 9:42 ` Jacopo Mondi
2024-09-10 9:55 ` Sakari Ailus
2024-09-10 10:06 ` Laurent Pinchart
2024-09-10 10:12 ` Tomi Valkeinen
2024-09-10 9:56 ` Tomi Valkeinen
2024-09-10 10:11 ` Laurent Pinchart
2024-09-10 10:21 ` Sakari Ailus
2024-09-10 10:26 ` Tomi Valkeinen [this message]
2024-09-10 10:18 ` Jacopo Mondi
2024-09-10 10:28 ` Tomi Valkeinen
2024-09-04 11:19 ` [PATCH v4 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6477da61-4e7f-418c-b586-39c7b34066f8@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®