From: David Lechner <dlechner@baylibre.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>,
jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org
Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/5] iio: ssp_sensors: use devm APIs for mutex and IRQ resources
Date: Sat, 11 Apr 2026 13:31:24 -0500 [thread overview]
Message-ID: <6479ec7b-a8b5-4154-8857-9e7c9af7ecc4@baylibre.com> (raw)
In-Reply-To: <438F2B61-7F4D-4488-82D0-E1EE23FBF766@gmail.com>
On 4/11/26 6:35 AM, Sanjay Chitroda wrote:
>
>
> Also, I observed that in remove() path, there is duplicate of following with ssp_disable_wdt_timer():
>
> static void ssp_remove(struct spi_device *spi)
> {
> ...
> ssp_disable_wdt_timer(data);
>
> ....
>
> timer_delete_sync(&data->wdt_timer);
> cancel_work_sync(&data->work_wdt);
>
> ...
> }
>
> static void ssp_disable_wdt_timer(data)(struct spi_device *spi)
> {
> timer_delete_sync(&data->wdt_timer);
> cancel_work_sync(&data->work_wdt);
> }
>
> At first glance looks redundant, do we require both ?
No, this sounds like a double-free bug.
next prev parent reply other threads:[~2026-04-11 18:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 8:08 [PATCH v5 0/5] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-06 8:08 ` [PATCH v5 1/5] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-06 18:33 ` Andy Shevchenko
2026-04-07 17:42 ` Sanjay Chitroda
2026-04-07 19:32 ` Andy Shevchenko
2026-04-06 8:08 ` [PATCH v5 2/5] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-04-06 8:08 ` [PATCH v5 3/5] iio: ssp_sensors: factor out pending list add/remove helpers Sanjay Chitroda
2026-04-06 20:04 ` Andy Shevchenko
2026-04-08 8:22 ` Sanjay Chitroda
[not found] ` <FA511CDD-1F98-4E66-BCE8-5156DBAF4359@gmail.com>
2026-04-08 11:36 ` Andy Shevchenko
2026-04-06 8:08 ` [PATCH v5 4/5] iio: ssp_sensors: use devm APIs for mutex and IRQ resources Sanjay Chitroda
2026-04-06 16:14 ` David Lechner
2026-04-11 11:35 ` Sanjay Chitroda
2026-04-11 18:31 ` David Lechner [this message]
2026-04-12 16:45 ` Sanjay Chitroda
2026-04-07 12:42 ` Andy Shevchenko
2026-04-11 11:41 ` Sanjay Chitroda
2026-04-06 8:08 ` [PATCH v5 5/5] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Sanjay Chitroda
2026-04-06 16:07 ` David Lechner
2026-04-11 11:57 ` Sanjay Chitroda
2026-04-11 12:17 ` Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6479ec7b-a8b5-4154-8857-9e7c9af7ecc4@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sanjayembeddedse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®