mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Matt Hartley" <matt.hartley@gmail.com>,
	"Kieran Levin" <ktl@framework.net>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Xinhui Pan" <Xinhui.Pan@amd.com>,
	"Jonathan Corbet" <corbet@lwn.net>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Dustin Howett <dustin@howett.net>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 3/4] drm: panel-backlight-quirks: Add Framework 13 matte panel
Date: Wed, 21 Aug 2024 15:54:56 -0500	[thread overview]
Message-ID: <647ee875-f932-46a9-b4e2-fb037a548754@amd.com> (raw)
In-Reply-To: <20240818-amdgpu-min-backlight-quirk-v5-3-b6c0ead0c73d@weissschuh.net>

On 8/18/2024 01:56, Thomas Weißschuh wrote:
> The value of "min_input_signal" returned from ATIF on a Framework AMD 13
> is "12". This leads to a fairly bright minimum display backlight.
> 
> Add a quirk to override that the minimum backlight PWM to "0" which
> leads to a much lower minimum brightness, which is still visible.
> 
> Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
> 
> Link: https://community.frame.work/t/25711/9
> Link: https://community.frame.work/t/47036
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> Tested-by: Dustin L. Howett <dustin@howett.net>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/gpu/drm/drm_panel_backlight_quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> index 6b8bbed77c7f..f2aefff618dd 100644
> --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
> @@ -17,6 +17,14 @@ struct drm_panel_min_backlight_quirk {
>   };
>   
>   static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks[] = {
> +	/* 13 inch matte panel */
> +	{
> +		.dmi_match.field = DMI_BOARD_VENDOR,
> +		.dmi_match.value = "Framework",
> +		.ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0bca),
> +		.ident.name = "NE135FBM-N41",
> +		.min_brightness = 0,
> +	},
>   };
>   
>   static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,
> 


  reply	other threads:[~2024-08-21 20:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-18  6:56 [PATCH v5 0/4] drm: Minimum backlight overrides and implementation for amdgpu Thomas Weißschuh
2024-08-18  6:56 ` [PATCH v5 1/4] drm: Add panel backlight quirks Thomas Weißschuh
2024-08-21 20:51   ` Mario Limonciello
2024-08-22  6:12     ` Thomas Weißschuh
2024-08-22 13:34       ` Mario Limonciello
2024-08-18  6:56 ` [PATCH v5 2/4] drm/amd/display: Add support for minimum backlight quirk Thomas Weißschuh
2024-08-21 20:54   ` Mario Limonciello
2024-08-22  6:14     ` Thomas Weißschuh
2024-08-22 13:34       ` Mario Limonciello
2024-08-18  6:56 ` [PATCH v5 3/4] drm: panel-backlight-quirks: Add Framework 13 matte panel Thomas Weißschuh
2024-08-21 20:54   ` Mario Limonciello [this message]
2024-08-18  6:56 ` [PATCH v5 4/4] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels Thomas Weißschuh
2024-08-21 20:55   ` Mario Limonciello
2024-08-21 20:45 ` [PATCH v5 0/4] drm: Minimum backlight overrides and implementation for amdgpu Mario Limonciello
2024-08-22  6:09   ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=647ee875-f932-46a9-b4e2-fb037a548754@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dustin@howett.net \
    --cc=harry.wentland@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=ktl@framework.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.hartley@gmail.com \
    --cc=mripard@kernel.org \
    --cc=sunpeng.li@amd.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®