mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guozihua (Scott)" <guozihua@huawei.com>
To: Jonathan Corbet <corbet@lwn.net>, <zohar@linux.ibm.com>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<roberto.sassu@huawei.com>, <wangweiyang2@huawei.com>,
	<xiujianfeng@huawei.com>, <linux-integrity@vger.kernel.org>
Subject: Re: [RESEND][PATCH] Documentation: added order requirement for ima_hash=
Date: Wed, 26 Jan 2022 10:32:47 +0800	[thread overview]
Message-ID: <64bb3746-07b4-aad4-7ee0-dccda6c7d4e1@huawei.com> (raw)
In-Reply-To: <87o83zwdxm.fsf@meer.lwn.net>



On 2022/1/26 8:14, Jonathan Corbet wrote:
> GUO Zihua <guozihua@huawei.com> writes:
> 
>> From: Guo Zihua <guozihua@huawei.com>
>>
>> Commandline parameter ima_hash= and ima_template= has order requirement
>> for them to work correctly together. Namely ima_hash= must be
>> specified after ima_template=, otherwise ima_template= will be ignored.
>>
>> The reason is that when handling ima_hash=, ima template would be set to
>> the default value if it has not been initialized already, and that value
>> cannot be changed afterwards by ima_template=.
>>
>> This patch adds this limitation to the documentation.
>>
>> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
>> Signed-off-by: Guo Zihua <guozihua@huawei.com>
> 
> I've applied this, but I'm wondering: where did this review take place?
> I can't find it on the lists...
> 
> Thanks,
> 
> jon
> .

Hi Jonathan,

Thank you very much and sorry for the confusion here. The reviewed by is 
more like a face-to-face peer review and I would like to mention that in 
the patch. If this is problematic I would stop doing that from now on.

-- 
Best
GUO Zihua

  reply	other threads:[~2022-01-26  2:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:02 GUO Zihua
2022-01-26  0:14 ` Jonathan Corbet
2022-01-26  2:32   ` Guozihua (Scott) [this message]
2022-01-26  1:07 ` Mimi Zohar
2022-01-26  2:28   ` Guozihua (Scott)
2022-01-26  4:37     ` Mimi Zohar
2022-01-26  7:41       ` Guozihua (Scott)
2022-01-26 12:47         ` Mimi Zohar
2022-01-26 13:24           ` Roberto Sassu
2022-01-26 14:34             ` Mimi Zohar
2022-01-26 14:43               ` Roberto Sassu
2022-01-26 16:31                 ` Jonathan Corbet
2022-01-27  6:35                 ` Guozihua (Scott)
2022-01-27 12:18                   ` Mimi Zohar
2022-01-28  9:32                     ` Guozihua (Scott)
2022-01-28 10:24           ` Roberto Sassu
2022-01-28 14:33             ` Mimi Zohar
2022-01-28 16:01               ` Roberto Sassu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64bb3746-07b4-aad4-7ee0-dccda6c7d4e1@huawei.com \
    --to=guozihua@huawei.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    --cc=wangweiyang2@huawei.com \
    --cc=xiujianfeng@huawei.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®