mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: qiwuchen55@gmail.com, mark@fasheh.com, jlbec@evilplan.org,
	trivial@kernel.org
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
	chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] ocfs2: remove trivial nowait check for buffered read/write
Date: Sun, 2 Feb 2020 17:01:25 +0800	[thread overview]
Message-ID: <64ca27c4-c3ee-2a43-3d97-35ad55e11472@linux.alibaba.com> (raw)
In-Reply-To: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com>



On 20/2/1 15:12, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> Remove trivial nowait check for buffered read/write, since
> buffered read is checked in generic_file_read_iter()->
> generic_file_buffered_read(), buffered write is checked in
> generic_write_checks().
> 
You are right, but check it at the beginning of
ocfs2_file_[read|write]_iter() will save much effort for lock ops, so
I'd like to leave them there.

Thanks,
Joseph

      reply	other threads:[~2020-02-02  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  7:12 qiwuchen55
2020-02-02  9:01 ` Joseph Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64ca27c4-c3ee-2a43-3d97-35ad55e11472@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=chenqiwu@xiaomi.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=qiwuchen55@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®