mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"jthoughton@google.com" <jthoughton@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] KVM: x86/mmu: Use LOCK CMPXCHG to clear Accessed bits
Date: Wed, 29 Jul 2026 22:04:19 +0000	[thread overview]
Message-ID: <64f162ab48f62d89c00375fac8f245342a1975bd.camel@intel.com> (raw)
In-Reply-To: <amoBN62nWqEgh0RE@google.com>

On Wed, 2026-07-29 at 06:33 -0700, Sean Christopherson wrote:
> On Wed, Jul 29, 2026, Kai Huang wrote:
> > On Mon, 2026-07-27 at 17:22 -0700, Sean Christopherson wrote:
> > > I initially was planning on tweaking the FROZEN_SPTE value to make it ok to
> > > use LOCK AND on Accessed bits, but AFAICT there's no meaningful downside to
> > > using CMPXCHG.
> > 
> > Maybe do both, e.g., still remove the A-bit from FROZEN_SPTE?  AFAICT there's no
> > good reason to keep the A-bit in FROZEN_SPTE.
> 
> Hmm, I'm leaning "no".
> 
> Once aging uses CMPXCHG, the A-bit isn't any more or less likely to be corrupted
> than any other bits.  And arguably, using the A-bit is "safer", because (a) it's
> got the same bit position on EPT and everything else, and (b) spuriously setting
> or clearing the bit is more likely to be benign.

OK makes sense :-)

My concern was if some new code comes up in the future to manipulate the A bit
then it may not be obvious the FROZEN_SPTE contains the A bit, but like you said
it's more likely to be benign.

  reply	other threads:[~2026-07-29 22:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  0:22 Sean Christopherson
2026-07-28  0:22 ` [PATCH 1/2] KVM: x86/mmu: Use CMPXCHG when clearing Accessed bit in TDP MMU Sean Christopherson
2026-07-28  0:31   ` James Houghton
2026-07-29 11:07   ` Huang, Kai
2026-07-28  0:22 ` [PATCH 2/2] KVM: x86/mmu: Use CMPXCHG when clearing Accessed bit in the shadow MMU Sean Christopherson
2026-07-28  0:34   ` James Houghton
2026-07-29 11:10   ` Huang, Kai
2026-07-29 11:12 ` [PATCH 0/2] KVM: x86/mmu: Use LOCK CMPXCHG to clear Accessed bits Huang, Kai
2026-07-29 13:33   ` Sean Christopherson
2026-07-29 22:04     ` Huang, Kai [this message]
2026-07-31 20:10 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64f162ab48f62d89c00375fac8f245342a1975bd.camel@intel.com \
    --to=kai.huang@intel.com \
    --cc=jthoughton@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome