Re: [PATCH] selftests: futex: Use variable MAKE instead of make

["André Almeida" <andrealmeid@collabora.com>]

Hi Usama,

Às 14:44 de 27/01/22, Muhammad Usama Anjum escreveu:
> Recursive make commands should always use the variable MAKE, not the
> explicit command name ‘make’. This has benefits and removes the
> following warning when multiple jobs are used for the build:
> 
> make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
> 
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Thanks for the patch!

Reviewed-by: André Almeida <andrealmeid@collabora.com>

> ---
>  tools/testing/selftests/futex/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 12631f0076a10..11e157d7533b8 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,7 +11,7 @@ all:
>  	@for DIR in $(SUBDIRS); do		\
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
> -		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> +		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>  		if [ -e $$DIR/$(TEST_PROGS) ]; then \
>  			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>  		fi \
> @@ -32,6 +32,6 @@ override define CLEAN
>  	@for DIR in $(SUBDIRS); do		\
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
> -		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> +		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>  	done
>  endef