* [PATCH] selftests: futex: Use variable MAKE instead of make
@ 2022-01-27 17:44 Muhammad Usama Anjum
2022-01-27 18:09 ` André Almeida
0 siblings, 1 reply; 3+ messages in thread
From: Muhammad Usama Anjum @ 2022-01-27 17:44 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Peter Zijlstra, Darren Hart,
Davidlohr Bueso, André Almeida, Shuah Khan,
Bamvor Jian Zhang
Cc: Muhammad Usama Anjum, kernel, linux-kernel, linux-kselftest
Recursive make commands should always use the variable MAKE, not the
explicit command name ‘make’. This has benefits and removes the
following warning when multiple jobs are used for the build:
make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
tools/testing/selftests/futex/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
index 12631f0076a10..11e157d7533b8 100644
--- a/tools/testing/selftests/futex/Makefile
+++ b/tools/testing/selftests/futex/Makefile
@@ -11,7 +11,7 @@ all:
@for DIR in $(SUBDIRS); do \
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
- make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
+ $(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
if [ -e $$DIR/$(TEST_PROGS) ]; then \
rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
fi \
@@ -32,6 +32,6 @@ override define CLEAN
@for DIR in $(SUBDIRS); do \
BUILD_TARGET=$(OUTPUT)/$$DIR; \
mkdir $$BUILD_TARGET -p; \
- make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
+ $(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
done
endef
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests: futex: Use variable MAKE instead of make
2022-01-27 17:44 [PATCH] selftests: futex: Use variable MAKE instead of make Muhammad Usama Anjum
@ 2022-01-27 18:09 ` André Almeida
2022-01-27 22:52 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: André Almeida @ 2022-01-27 18:09 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: kernel, linux-kernel, Ingo Molnar, Thomas Gleixner, Darren Hart,
Peter Zijlstra, linux-kselftest, Shuah Khan, Davidlohr Bueso,
Bamvor Jian Zhang
Hi Usama,
Às 14:44 de 27/01/22, Muhammad Usama Anjum escreveu:
> Recursive make commands should always use the variable MAKE, not the
> explicit command name ‘make’. This has benefits and removes the
> following warning when multiple jobs are used for the build:
>
> make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
>
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Thanks for the patch!
Reviewed-by: André Almeida <andrealmeid@collabora.com>
> ---
> tools/testing/selftests/futex/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 12631f0076a10..11e157d7533b8 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,7 +11,7 @@ all:
> @for DIR in $(SUBDIRS); do \
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> - make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> + $(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> if [ -e $$DIR/$(TEST_PROGS) ]; then \
> rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> fi \
> @@ -32,6 +32,6 @@ override define CLEAN
> @for DIR in $(SUBDIRS); do \
> BUILD_TARGET=$(OUTPUT)/$$DIR; \
> mkdir $$BUILD_TARGET -p; \
> - make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> + $(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> done
> endef
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests: futex: Use variable MAKE instead of make
2022-01-27 18:09 ` André Almeida
@ 2022-01-27 22:52 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2022-01-27 22:52 UTC (permalink / raw)
To: André Almeida, Muhammad Usama Anjum
Cc: kernel, linux-kernel, Ingo Molnar, Thomas Gleixner, Darren Hart,
Peter Zijlstra, linux-kselftest, Shuah Khan, Davidlohr Bueso,
Bamvor Jian Zhang, Shuah Khan
On 1/27/22 11:09 AM, André Almeida wrote:
> Hi Usama,
>
> Às 14:44 de 27/01/22, Muhammad Usama Anjum escreveu:
>> Recursive make commands should always use the variable MAKE, not the
>> explicit command name ‘make’. This has benefits and removes the
>> following warning when multiple jobs are used for the build:
>>
>> make[2]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
>>
>> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
> Thanks for the patch!
>
> Reviewed-by: André Almeida <andrealmeid@collabora.com>
>
Thank you for the patch. Applied to linux-kselftest fixes for rc3
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-27 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 17:44 [PATCH] selftests: futex: Use variable MAKE instead of make Muhammad Usama Anjum
2022-01-27 18:09 ` André Almeida
2022-01-27 22:52 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome