mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Cc: rostedt@goodmis.org, tglx@linutronix.de, C.Emde@osadl.org,
	jkacur@redhat.com, bigeasy@linutronix.de,
	daniel.wagner@siemens.com, julia@ni.com,
	stable-rt@vger.kernel.org,
	Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH 08/15] seqlock: provide the same ordering semantics as mainline
Date: Thu,  2 Aug 2018 17:25:23 -0500	[thread overview]
Message-ID: <650bfc722354f3307e6390ddddf1e4ee4e9dced2.1533242791.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1533242791.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1533242791.git.tom.zanussi@linux.intel.com>

From: Julia Cartwright <julia@ni.com>

The mainline implementation of read_seqbegin() orders prior loads w.r.t.
the read-side critical section.  Fixup the RT writer-boosting
implementation to provide the same guarantee.

Also, while we're here, update the usage of ACCESS_ONCE() to use
READ_ONCE().

Fixes: e69f15cf77c23 ("seqlock: Prevent rt starvation")
Cc: stable-rt@vger.kernel.org
Signed-off-by: Julia Cartwright <julia@ni.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
(cherry picked from commit afa4c06b89a3c0fb7784ff900ccd707bef519cb7)
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
 include/linux/seqlock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 4acd0e2fb5cb..efa234031230 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -338,6 +338,7 @@ repeat:
 		spin_unlock_wait(&sl->lock);
 		goto repeat;
 	}
+	smp_rmb();
 	return ret;
 }
 #endif
-- 
2.14.1


  parent reply	other threads:[~2018-08-02 22:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 22:25 [PATCH 00/15][ANNOUNCE] 3.18.117-rt105-rc1 Tom Zanussi
2018-08-02 22:25 ` [PATCH 01/15] sched: Remove TASK_ALL Tom Zanussi
2018-08-02 22:25 ` [PATCH 02/15] arm*: disable NEON in kernel mode Tom Zanussi
2018-08-02 22:25 ` [PATCH 03/15] posix-timers: move the rcu head out of the union Tom Zanussi
2018-08-02 22:25 ` [PATCH 04/15] tracing: Fix rcu splat from idle CPU on boot Tom Zanussi
2018-08-02 22:25 ` [PATCH 05/15] alarmtimer: Prevent live lock in alarm_cancel() Tom Zanussi
2018-08-02 22:25 ` [PATCH 06/15] locking: add types.h Tom Zanussi
2018-08-02 22:25 ` [PATCH 07/15] net: use task_struct instead of CPU number as the queue owner on -RT Tom Zanussi
2018-08-02 22:25 ` Tom Zanussi [this message]
2018-08-02 22:25 ` [PATCH 09/15] squashfs: make use of local lock in multi_cpu decompressor Tom Zanussi
2018-08-02 22:25 ` [PATCH 10/15] Revert "fs, jbd: pull your plug when waiting for space" Tom Zanussi
2018-08-03  7:32 ` [PATCH 00/15][ANNOUNCE] 3.18.117-rt105-rc1 Sebastian Andrzej Siewior
2018-08-03 13:34   ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650bfc722354f3307e6390ddddf1e4ee4e9dced2.1533242791.git.tom.zanussi@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=daniel.wagner@siemens.com \
    --cc=jkacur@redhat.com \
    --cc=julia@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®