From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Cc: rostedt@goodmis.org, tglx@linutronix.de, C.Emde@osadl.org,
jkacur@redhat.com, bigeasy@linutronix.de,
daniel.wagner@siemens.com, julia@ni.com,
stable-rt@vger.kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH 05/15] alarmtimer: Prevent live lock in alarm_cancel()
Date: Thu, 2 Aug 2018 17:25:20 -0500 [thread overview]
Message-ID: <f83843102b0b0be99a3504aff0e41ddbb91e8f44.1533242791.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1533242791.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1533242791.git.tom.zanussi@linux.intel.com>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
If alarm_try_to_cancel() requires a retry, then depending on the
priority setting the retry loop might prevent timer callback completion
on RT. Prevent that by waiting for completion on RT, no change for a
non RT kernel.
Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
(cherry picked from commit 51e376c469bf05f32cb1ceb9e39d31bb92f1f6c8)
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
kernel/time/alarmtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 119847b93ba6..5a5e05fc92a3 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -395,7 +395,7 @@ int alarm_cancel(struct alarm *alarm)
int ret = alarm_try_to_cancel(alarm);
if (ret >= 0)
return ret;
- cpu_relax();
+ hrtimer_wait_for_timer(&alarm->timer);
}
}
EXPORT_SYMBOL_GPL(alarm_cancel);
--
2.14.1
next prev parent reply other threads:[~2018-08-02 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 22:25 [PATCH 00/15][ANNOUNCE] 3.18.117-rt105-rc1 Tom Zanussi
2018-08-02 22:25 ` [PATCH 01/15] sched: Remove TASK_ALL Tom Zanussi
2018-08-02 22:25 ` [PATCH 02/15] arm*: disable NEON in kernel mode Tom Zanussi
2018-08-02 22:25 ` [PATCH 03/15] posix-timers: move the rcu head out of the union Tom Zanussi
2018-08-02 22:25 ` [PATCH 04/15] tracing: Fix rcu splat from idle CPU on boot Tom Zanussi
2018-08-02 22:25 ` Tom Zanussi [this message]
2018-08-02 22:25 ` [PATCH 06/15] locking: add types.h Tom Zanussi
2018-08-02 22:25 ` [PATCH 07/15] net: use task_struct instead of CPU number as the queue owner on -RT Tom Zanussi
2018-08-02 22:25 ` [PATCH 08/15] seqlock: provide the same ordering semantics as mainline Tom Zanussi
2018-08-02 22:25 ` [PATCH 09/15] squashfs: make use of local lock in multi_cpu decompressor Tom Zanussi
2018-08-02 22:25 ` [PATCH 10/15] Revert "fs, jbd: pull your plug when waiting for space" Tom Zanussi
2018-08-03 7:32 ` [PATCH 00/15][ANNOUNCE] 3.18.117-rt105-rc1 Sebastian Andrzej Siewior
2018-08-03 13:34 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83843102b0b0be99a3504aff0e41ddbb91e8f44.1533242791.git.tom.zanussi@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=daniel.wagner@siemens.com \
--cc=jkacur@redhat.com \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®