[PATCH] drivers/spi-nor: add support for Winbond w25q01jv

[PATCH] drivers/spi-nor: add support for Winbond w25q01jv

[Heyi Guo]

Winbond W25Q01JV is a 128MB SPI-NOR flash chip.

Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com>

--
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: Pratyush Yadav <pratyush@kernel.org>
Cc: Michael Walle <michael@walle.cc>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/spi-nor/winbond.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ca39acf4112c8..0cd49f534bf8d 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -142,6 +142,9 @@ static const struct flash_info winbond_nor_parts[] = {
 	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
 			      SPI_NOR_QUAD_READ) },
+	{ "w25q01jv", INFO(0xef4021, 0, 64 * 1024, 2048)
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+			      SPI_NOR_QUAD_READ) },
 };
 
 /**
-- 
2.17.1

Re: [PATCH] drivers/spi-nor: add support for Winbond w25q01jv

[Michael Walle]

Hi,

> Winbond W25Q01JV is a 128MB SPI-NOR flash chip.
> 
> Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com>
> 
> --
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/spi-nor/winbond.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c 
> b/drivers/mtd/spi-nor/winbond.c
> index ca39acf4112c8..0cd49f534bf8d 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -142,6 +142,9 @@ static const struct flash_info winbond_nor_parts[] 
> = {
>  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>  			      SPI_NOR_QUAD_READ) },
> +	{ "w25q01jv", INFO(0xef4021, 0, 64 * 1024, 2048)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> +			      SPI_NOR_QUAD_READ) },

I'd guess this flash has SFDP support, correct? In this case,
could you please try the latest next (or -rc) kernel without
this change? In the meantime we have a generic spi-nor driver [1]
so you don't need a new entry in most cases.

Apart from that, it would be nice if you could dump the
SFDP tables, see [2].

-michael

[1] 
https://elixir.bootlin.com/linux/v6.2-rc5/source/drivers/mtd/spi-nor/core.c#L1638
[2] https://lore.kernel.org/r/4304e19f3399a0a6e856119d01ccabe0@walle.cc/

Re: [PATCH] drivers/spi-nor: add support for Winbond w25q01jv

[Heyi Guo]

On 2023/1/30 下午5:29, Michael Walle wrote:
> Hi,
>
>> Winbond W25Q01JV is a 128MB SPI-NOR flash chip.
>>
>> Signed-off-by: Heyi Guo <guoheyi@linux.alibaba.com>
>>
>> -- 
>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
>> Cc: Pratyush Yadav <pratyush@kernel.org>
>> Cc: Michael Walle <michael@walle.cc>
>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>>  drivers/mtd/spi-nor/winbond.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/winbond.c 
>> b/drivers/mtd/spi-nor/winbond.c
>> index ca39acf4112c8..0cd49f534bf8d 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -142,6 +142,9 @@ static const struct flash_info 
>> winbond_nor_parts[] = {
>>      { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
>>          NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>>                    SPI_NOR_QUAD_READ) },
>> +    { "w25q01jv", INFO(0xef4021, 0, 64 * 1024, 2048)
>> +        NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>> +                  SPI_NOR_QUAD_READ) },
>
> I'd guess this flash has SFDP support, correct?

Yes, the spec says it supports SFDP :)


> In this case,
> could you please try the latest next (or -rc) kernel without
> this change?

Is v6.2-rc3 OK for the test? If so, surely I can do that.

Thanks for your comments :)

Heyi


> In the meantime we have a generic spi-nor driver [1]
> so you don't need a new entry in most cases.
>
> Apart from that, it would be nice if you could dump the
> SFDP tables, see [2].
>
> -michael
>
> [1] 
> https://elixir.bootlin.com/linux/v6.2-rc5/source/drivers/mtd/spi-nor/core.c#L1638
> [2] https://lore.kernel.org/r/4304e19f3399a0a6e856119d01ccabe0@walle.cc/

Re: [PATCH] drivers/spi-nor: add support for Winbond w25q01jv

[Michael Walle]

Hi,

> Is v6.2-rc3 OK for the test? If so, surely I can do that.

Yes, that should already contain the generic driver.

-michael