From: Dan Williams <dan.j.williams@intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>,
<nvdimm@lists.linux.dev>, <linux-acpi@vger.kernel.org>,
<dan.j.williams@intel.com>
Cc: <rafael@kernel.org>, <vishal.l.verma@intel.com>,
<lenb@kernel.org>, <dave.jiang@intel.com>, <ira.weiny@intel.com>,
<linux-kernel@vger.kernel.org>,
Michal Wilczynski <michal.wilczynski@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] ACPI: NFIT: Fix local use of devm_*()
Date: Fri, 13 Oct 2023 09:38:22 -0700 [thread overview]
Message-ID: <6529727e18964_f879294ea@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20231013085722.3031537-1-michal.wilczynski@intel.com>
Michal Wilczynski wrote:
> devm_*() family of functions purpose is managing memory attached to a
> device. So in general it should only be used for allocations that should
> last for the whole lifecycle of the device.
No, this assertion is not accurate, if it were strictly true then
devm_kfree() should be deleted. This patch is only a cleanup to switch
the automatic cleanup pattern from devm to the new cleanup.h helpers.
I am all for modernizing code over time, but patches that make
assertions of "memory leaks" and "incorrect API usage" in code that has
been untouched for almost a decade demand more scrutiny than what
transpired here.
next prev parent reply other threads:[~2023-10-13 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:57 Michal Wilczynski
2023-10-13 16:38 ` Dan Williams [this message]
2023-10-13 17:00 ` Wilczynski, Michal
2023-10-13 17:05 ` Dan Williams
2023-10-13 17:18 ` Wilczynski, Michal
2023-10-13 21:20 ` Dan Williams
2023-10-14 10:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6529727e18964_f879294ea@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®