* [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga()
@ 2025-11-21 5:21 Jinhui Guo
2025-11-21 8:14 ` Vasant Hegde
2025-11-25 14:14 ` Jörg Rödel
0 siblings, 2 replies; 3+ messages in thread
From: Jinhui Guo @ 2025-11-21 5:21 UTC (permalink / raw)
To: joro, suravee.suthikulpanit, Ankit.Soni
Cc: guojinhui.liam, iommu, linux-kernel, stable
The return type of __modify_irte_ga() is int, but modify_irte_ga()
treats it as a bool. Casting the int to bool discards the error code.
To fix the issue, change the type of ret to int in modify_irte_ga().
Fixes: 57cdb720eaa5 ("iommu/amd: Do not flush IRTE when only updating isRun and destination fields")
Cc: stable@vger.kernel.org
Signed-off-by: Jinhui Guo <guojinhui.liam@bytedance.com>
Reviewed-by: Ankit Soni <Ankit.Soni@amd.com>
---
v1: https://lore.kernel.org/all/20251120154725.435-1-guojinhui.liam@bytedance.com/
Changelog in v1 -> v2 (suggested by Ankit Soni)
- Trim subject line to the recommanded length
drivers/iommu/amd/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 2e1865daa1ce..a38304f1a8df 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -3354,7 +3354,7 @@ static int __modify_irte_ga(struct amd_iommu *iommu, u16 devid, int index,
static int modify_irte_ga(struct amd_iommu *iommu, u16 devid, int index,
struct irte_ga *irte)
{
- bool ret;
+ int ret;
ret = __modify_irte_ga(iommu, devid, index, irte);
if (ret)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga()
2025-11-21 5:21 [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga() Jinhui Guo
@ 2025-11-21 8:14 ` Vasant Hegde
2025-11-25 14:14 ` Jörg Rödel
1 sibling, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2025-11-21 8:14 UTC (permalink / raw)
To: Jinhui Guo, joro, suravee.suthikulpanit, Ankit.Soni
Cc: iommu, linux-kernel, stable
On 11/21/2025 10:51 AM, Jinhui Guo wrote:
> The return type of __modify_irte_ga() is int, but modify_irte_ga()
> treats it as a bool. Casting the int to bool discards the error code.
>
> To fix the issue, change the type of ret to int in modify_irte_ga().
>
> Fixes: 57cdb720eaa5 ("iommu/amd: Do not flush IRTE when only updating isRun and destination fields")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jinhui Guo <guojinhui.liam@bytedance.com>
> Reviewed-by: Ankit Soni <Ankit.Soni@amd.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga()
2025-11-21 5:21 [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga() Jinhui Guo
2025-11-21 8:14 ` Vasant Hegde
@ 2025-11-25 14:14 ` Jörg Rödel
1 sibling, 0 replies; 3+ messages in thread
From: Jörg Rödel @ 2025-11-25 14:14 UTC (permalink / raw)
To: Jinhui Guo; +Cc: suravee.suthikulpanit, Ankit.Soni, iommu, linux-kernel, stable
On Fri, Nov 21, 2025 at 01:21:39PM +0800, Jinhui Guo wrote:
> Changelog in v1 -> v2 (suggested by Ankit Soni)
> - Trim subject line to the recommanded length
Applied v1, and as checkpatch did not complain, I guess the subject line was
fine, so not replacing it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-25 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-21 5:21 [PATCH v2] iommu/amd: Relay __modify_irte_ga() error in modify_irte_ga() Jinhui Guo
2025-11-21 8:14 ` Vasant Hegde
2025-11-25 14:14 ` Jörg Rödel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®