mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yue Hu <zbestahu@gmail.com>, Yangtao Li <frank.li@vivo.com>
Cc: xiang@kernel.org, chao@kernel.org, jefflexu@linux.alibaba.com,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
Date: Fri, 3 Mar 2023 14:25:19 +0800	[thread overview]
Message-ID: <65437f0e-dea9-115e-decd-b34cd8c79f81@linux.alibaba.com> (raw)
In-Reply-To: <20230303140405.000035a6.zbestahu@gmail.com>



On 2023/3/3 14:04, Yue Hu wrote:
> On Fri,  3 Mar 2023 11:14:18 +0800
> Yangtao Li <frank.li@vivo.com> wrote:
> 
>> They are used during the erofs module init phase. Let's mark it as
>> __init like any other function.
>>
>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
>> ---
>>   fs/erofs/decompressor_lzma.c | 2 +-
>>   fs/erofs/pcpubuf.c           | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
>> index 091fd5adf818..307b37f0b9f5 100644
>> --- a/fs/erofs/decompressor_lzma.c
>> +++ b/fs/erofs/decompressor_lzma.c
>> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
>>   	}
>>   }
>>   
>> -int z_erofs_lzma_init(void)
>> +int __init z_erofs_lzma_init(void)
>>   {
>>   	unsigned int i;
>>   
>> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
>> index a2efd833d1b6..c7a4b1d77069 100644
>> --- a/fs/erofs/pcpubuf.c
>> +++ b/fs/erofs/pcpubuf.c
>> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
>>   	return ret;
>>   }
>>   
>> -void erofs_pcpubuf_init(void)
>> +void __init erofs_pcpubuf_init(void)
>>   {
>>   	int cpu;
>>   
> 
> Update them in internal.h as well?

Yeah, please help revise, thanks!

Thanks,
Gao Xiang


      reply	other threads:[~2023-03-03  6:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03  3:14 Yangtao Li
2023-03-03  4:10 ` Gao Xiang
2023-03-03  6:04 ` Yue Hu
2023-03-03  6:25   ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65437f0e-dea9-115e-decd-b34cd8c79f81@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=frank.li@vivo.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®