* [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
@ 2023-03-03 3:14 Yangtao Li
2023-03-03 4:10 ` Gao Xiang
2023-03-03 6:04 ` Yue Hu
0 siblings, 2 replies; 4+ messages in thread
From: Yangtao Li @ 2023-03-03 3:14 UTC (permalink / raw)
To: xiang, chao, huyue2, jefflexu; +Cc: linux-erofs, linux-kernel, Yangtao Li
They are used during the erofs module init phase. Let's mark it as
__init like any other function.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
fs/erofs/decompressor_lzma.c | 2 +-
fs/erofs/pcpubuf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
index 091fd5adf818..307b37f0b9f5 100644
--- a/fs/erofs/decompressor_lzma.c
+++ b/fs/erofs/decompressor_lzma.c
@@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
}
}
-int z_erofs_lzma_init(void)
+int __init z_erofs_lzma_init(void)
{
unsigned int i;
diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
index a2efd833d1b6..c7a4b1d77069 100644
--- a/fs/erofs/pcpubuf.c
+++ b/fs/erofs/pcpubuf.c
@@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
return ret;
}
-void erofs_pcpubuf_init(void)
+void __init erofs_pcpubuf_init(void)
{
int cpu;
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
2023-03-03 3:14 [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init Yangtao Li
@ 2023-03-03 4:10 ` Gao Xiang
2023-03-03 6:04 ` Yue Hu
1 sibling, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2023-03-03 4:10 UTC (permalink / raw)
To: Yangtao Li, xiang, chao, huyue2, jefflexu; +Cc: linux-erofs, linux-kernel
On 2023/3/3 11:14, Yangtao Li wrote:
> They are used during the erofs module init phase. Let's mark it as
> __init like any other function.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
> ---
> fs/erofs/decompressor_lzma.c | 2 +-
> fs/erofs/pcpubuf.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
> index 091fd5adf818..307b37f0b9f5 100644
> --- a/fs/erofs/decompressor_lzma.c
> +++ b/fs/erofs/decompressor_lzma.c
> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
> }
> }
>
> -int z_erofs_lzma_init(void)
> +int __init z_erofs_lzma_init(void)
> {
> unsigned int i;
>
> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
> index a2efd833d1b6..c7a4b1d77069 100644
> --- a/fs/erofs/pcpubuf.c
> +++ b/fs/erofs/pcpubuf.c
> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
> return ret;
> }
>
> -void erofs_pcpubuf_init(void)
> +void __init erofs_pcpubuf_init(void)
> {
> int cpu;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
2023-03-03 3:14 [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init Yangtao Li
2023-03-03 4:10 ` Gao Xiang
@ 2023-03-03 6:04 ` Yue Hu
2023-03-03 6:25 ` Gao Xiang
1 sibling, 1 reply; 4+ messages in thread
From: Yue Hu @ 2023-03-03 6:04 UTC (permalink / raw)
To: Yangtao Li; +Cc: xiang, chao, jefflexu, linux-erofs, linux-kernel
On Fri, 3 Mar 2023 11:14:18 +0800
Yangtao Li <frank.li@vivo.com> wrote:
> They are used during the erofs module init phase. Let's mark it as
> __init like any other function.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/erofs/decompressor_lzma.c | 2 +-
> fs/erofs/pcpubuf.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
> index 091fd5adf818..307b37f0b9f5 100644
> --- a/fs/erofs/decompressor_lzma.c
> +++ b/fs/erofs/decompressor_lzma.c
> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
> }
> }
>
> -int z_erofs_lzma_init(void)
> +int __init z_erofs_lzma_init(void)
> {
> unsigned int i;
>
> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
> index a2efd833d1b6..c7a4b1d77069 100644
> --- a/fs/erofs/pcpubuf.c
> +++ b/fs/erofs/pcpubuf.c
> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
> return ret;
> }
>
> -void erofs_pcpubuf_init(void)
> +void __init erofs_pcpubuf_init(void)
> {
> int cpu;
>
Update them in internal.h as well?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init
2023-03-03 6:04 ` Yue Hu
@ 2023-03-03 6:25 ` Gao Xiang
0 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2023-03-03 6:25 UTC (permalink / raw)
To: Yue Hu, Yangtao Li; +Cc: xiang, chao, jefflexu, linux-erofs, linux-kernel
On 2023/3/3 14:04, Yue Hu wrote:
> On Fri, 3 Mar 2023 11:14:18 +0800
> Yangtao Li <frank.li@vivo.com> wrote:
>
>> They are used during the erofs module init phase. Let's mark it as
>> __init like any other function.
>>
>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
>> ---
>> fs/erofs/decompressor_lzma.c | 2 +-
>> fs/erofs/pcpubuf.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/erofs/decompressor_lzma.c b/fs/erofs/decompressor_lzma.c
>> index 091fd5adf818..307b37f0b9f5 100644
>> --- a/fs/erofs/decompressor_lzma.c
>> +++ b/fs/erofs/decompressor_lzma.c
>> @@ -47,7 +47,7 @@ void z_erofs_lzma_exit(void)
>> }
>> }
>>
>> -int z_erofs_lzma_init(void)
>> +int __init z_erofs_lzma_init(void)
>> {
>> unsigned int i;
>>
>> diff --git a/fs/erofs/pcpubuf.c b/fs/erofs/pcpubuf.c
>> index a2efd833d1b6..c7a4b1d77069 100644
>> --- a/fs/erofs/pcpubuf.c
>> +++ b/fs/erofs/pcpubuf.c
>> @@ -114,7 +114,7 @@ int erofs_pcpubuf_growsize(unsigned int nrpages)
>> return ret;
>> }
>>
>> -void erofs_pcpubuf_init(void)
>> +void __init erofs_pcpubuf_init(void)
>> {
>> int cpu;
>>
>
> Update them in internal.h as well?
Yeah, please help revise, thanks!
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-03 6:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-03 3:14 [PATCH] erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init Yangtao Li
2023-03-03 4:10 ` Gao Xiang
2023-03-03 6:04 ` Yue Hu
2023-03-03 6:25 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®