From: Dave Hansen <dave.hansen@intel.com>
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: David.Laight@ACULAB.COM, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, tglx@linutronix.de, wei.liu@kernel.org,
x86@kernel.org
Subject: Re: [RESEND PATCH v2] x86/apic: Use u32 instead of unsigned long
Date: Fri, 8 Mar 2024 08:12:48 -0800 [thread overview]
Message-ID: <656ade98-c8aa-42df-8926-d0513e105816@intel.com> (raw)
In-Reply-To: <20240308124336.41654-2-thorsten.blum@toblux.com>
On 3/8/24 04:43, Thorsten Blum wrote:
> Improve types by using u32 instead of unsigned long. Fixes two
> Coccinelle/coccicheck warnings reported by do_div.cocci.
This seems simple enough, but the changelog and subject are really
lacking in substantive information.
The _patch_ literally does a few s/unsigned long/u32/ operations, and
that's just repeated pretty much verbatim in the changelog and subject.
So it just tells me two more times what I already know.
Without going and running do_div.cocci I can't tell whether the warnings
are good checks or nonsense. I also don't know _which_ do_div()s the
warnings even refer to.
Could we get a _little_ more meat in here, please?
next prev parent reply other threads:[~2024-03-08 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 11:43 [PATCH] x86/apic: Use div64_ul() instead of do_div() Thorsten Blum
2024-02-29 22:13 ` David Laight
2024-03-01 1:01 ` H. Peter Anvin
2024-03-01 8:53 ` David Laight
2024-03-01 12:28 ` Thorsten Blum
2024-03-01 20:39 ` [PATCH v2] x86/apic: Use u32 instead of unsigned long Thorsten Blum
2024-03-08 12:43 ` [RESEND PATCH " Thorsten Blum
2024-03-08 16:12 ` Dave Hansen [this message]
2024-03-08 19:50 ` Thorsten Blum
2024-03-08 23:02 ` [PATCH v3] x86/apic: Improve data types to fix Coccinelle warnings Thorsten Blum
2024-03-18 10:47 ` [RESEND PATCH " Thorsten Blum
2024-03-18 16:13 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656ade98-c8aa-42df-8926-d0513e105816@intel.com \
--to=dave.hansen@intel.com \
--cc=David.Laight@ACULAB.COM \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@toblux.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®