[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[sunran001]

Fix nine occurrences of the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/atom.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atom.c 
b/drivers/gpu/drm/radeon/atom.c
index c1bbfbe28bda..11a1940bb26d 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -1156,7 +1156,7 @@ static struct {
      atom_op_shr, ATOM_ARG_MC}, {
  atom_op_debug, 0},};

-static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t * params)
+static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t *params)
  {
      int base = CU16(ctx->cmd_table + 4 + 2 * index);
      int len, ws, ps, ptr;
@@ -1216,7 +1216,7 @@ static int atom_execute_table_locked(struct 
atom_context *ctx, int index, uint32
      return ret;
  }

-int atom_execute_table_scratch_unlocked(struct atom_context *ctx, int 
index, uint32_t * params)
+int atom_execute_table_scratch_unlocked(struct atom_context *ctx, int 
index, uint32_t *params)
  {
      int r;

@@ -1237,7 +1237,7 @@ int atom_execute_table_scratch_unlocked(struct 
atom_context *ctx, int index, uin
      return r;
  }

-int atom_execute_table(struct atom_context *ctx, int index, uint32_t * 
params)
+int atom_execute_table(struct atom_context *ctx, int index, uint32_t 
*params)
  {
      int r;
      mutex_lock(&ctx->scratch_mutex);
@@ -1359,8 +1359,8 @@ void atom_destroy(struct atom_context *ctx)
  }

  bool atom_parse_data_header(struct atom_context *ctx, int index,
-                uint16_t * size, uint8_t * frev, uint8_t * crev,
-                uint16_t * data_start)
+                uint16_t *size, uint8_t *frev, uint8_t *crev,
+                uint16_t *data_start)
  {
      int offset = index * 2 + 4;
      int idx = CU16(ctx->data_table + offset);
@@ -1379,8 +1379,8 @@ bool atom_parse_data_header(struct atom_context 
*ctx, int index,
      return true;
  }

-bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t 
* frev,
-               uint8_t * crev)
+bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t 
*frev,
+               uint8_t *crev)
  {
      int offset = index * 2 + 4;
      int idx = CU16(ctx->cmd_table + offset);

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[Alex Deucher]

Applied.  Thanks!

On Mon, Jul 10, 2023 at 3:38 AM <sunran001@208suo.com> wrote:
>
> Fix nine occurrences of the checkpatch.pl error:
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/atom.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c
> b/drivers/gpu/drm/radeon/atom.c
> index c1bbfbe28bda..11a1940bb26d 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -1156,7 +1156,7 @@ static struct {
>       atom_op_shr, ATOM_ARG_MC}, {
>   atom_op_debug, 0},};
>
> -static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t * params)
> +static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t *params)
>   {
>       int base = CU16(ctx->cmd_table + 4 + 2 * index);
>       int len, ws, ps, ptr;
> @@ -1216,7 +1216,7 @@ static int atom_execute_table_locked(struct
> atom_context *ctx, int index, uint32
>       return ret;
>   }
>
> -int atom_execute_table_scratch_unlocked(struct atom_context *ctx, int
> index, uint32_t * params)
> +int atom_execute_table_scratch_unlocked(struct atom_context *ctx, int
> index, uint32_t *params)
>   {
>       int r;
>
> @@ -1237,7 +1237,7 @@ int atom_execute_table_scratch_unlocked(struct
> atom_context *ctx, int index, uin
>       return r;
>   }
>
> -int atom_execute_table(struct atom_context *ctx, int index, uint32_t *
> params)
> +int atom_execute_table(struct atom_context *ctx, int index, uint32_t
> *params)
>   {
>       int r;
>       mutex_lock(&ctx->scratch_mutex);
> @@ -1359,8 +1359,8 @@ void atom_destroy(struct atom_context *ctx)
>   }
>
>   bool atom_parse_data_header(struct atom_context *ctx, int index,
> -                uint16_t * size, uint8_t * frev, uint8_t * crev,
> -                uint16_t * data_start)
> +                uint16_t *size, uint8_t *frev, uint8_t *crev,
> +                uint16_t *data_start)
>   {
>       int offset = index * 2 + 4;
>       int idx = CU16(ctx->data_table + offset);
> @@ -1379,8 +1379,8 @@ bool atom_parse_data_header(struct atom_context
> *ctx, int index,
>       return true;
>   }
>
> -bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t
> * frev,
> -               uint8_t * crev)
> +bool atom_parse_cmd_header(struct atom_context *ctx, int index, uint8_t
> *frev,
> +               uint8_t *crev)
>   {
>       int offset = index * 2 + 4;
>       int idx = CU16(ctx->cmd_table + offset);

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[Alex Deucher]

I applied the same patch from Ran yesterday.

Thanks!

Alex

On Tue, Jul 25, 2023 at 9:23 AM <wuyonggang001@208suo.com> wrote:
>
> Fix the error(s):
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/atom.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c
> b/drivers/gpu/drm/radeon/atom.c
> index 11a1940bb26d..93acb0e42bd6 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -68,8 +68,8 @@ typedef struct {
>   } atom_exec_context;
>
>   int atom_debug = 0;
> -static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t * params);
> -int atom_execute_table(struct atom_context *ctx, int index, uint32_t *
> params);
> +static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t *params);
> +int atom_execute_table(struct atom_context *ctx, int index, uint32_t
> *params);
>
>   static uint32_t atom_arg_mask[8] = {
>         0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[wuyonggang001]

Fix the error(s):
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
---
  drivers/gpu/drm/radeon/atom.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atom.c 
b/drivers/gpu/drm/radeon/atom.c
index 11a1940bb26d..93acb0e42bd6 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -68,8 +68,8 @@ typedef struct {
  } atom_exec_context;

  int atom_debug = 0;
-static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t * params);
-int atom_execute_table(struct atom_context *ctx, int index, uint32_t * 
params);
+static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t *params);
+int atom_execute_table(struct atom_context *ctx, int index, uint32_t 
*params);

  static uint32_t atom_arg_mask[8] = {
  	0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[Alex Deucher]

Applied.  Thanks!

On Fri, Jul 21, 2023 at 2:10 AM <sunran001@208suo.com> wrote:
>
> Fix nine occurrences of the checkpatch.pl error:
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/atom.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c
> b/drivers/gpu/drm/radeon/atom.c
> index 11a1940bb26d..93acb0e42bd6 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -68,8 +68,8 @@ typedef struct {
>   } atom_exec_context;
>
>   int atom_debug = 0;
> -static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t * params);
> -int atom_execute_table(struct atom_context *ctx, int index, uint32_t *
> params);
> +static int atom_execute_table_locked(struct atom_context *ctx, int
> index, uint32_t *params);
> +int atom_execute_table(struct atom_context *ctx, int index, uint32_t
> *params);
>
>   static uint32_t atom_arg_mask[8] = {
>         0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[sunran001]

Fix two occurrences of the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Jianghui Xu <xujianghui@cdjrlc.com>
---
  drivers/gpu/drm/radeon/atom.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atom.c 
b/drivers/gpu/drm/radeon/atom.c
index 11a1940bb26d..93acb0e42bd6 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -68,8 +68,8 @@ typedef struct {
  } atom_exec_context;

  int atom_debug = 0;
-static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t * params);
-int atom_execute_table(struct atom_context *ctx, int index, uint32_t * 
params);
+static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t *params);
+int atom_execute_table(struct atom_context *ctx, int index, uint32_t 
*params);

  static uint32_t atom_arg_mask[8] = {
  	0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[sunran001]

Fix two occurrences of the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/atom.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atom.c 
b/drivers/gpu/drm/radeon/atom.c
index 11a1940bb26d..93acb0e42bd6 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -68,8 +68,8 @@ typedef struct {
  } atom_exec_context;

  int atom_debug = 0;
-static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t * params);
-int atom_execute_table(struct atom_context *ctx, int index, uint32_t * 
params);
+static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t *params);
+int atom_execute_table(struct atom_context *ctx, int index, uint32_t 
*params);

  static uint32_t atom_arg_mask[8] = {
  	0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

[sunran001]

Fix nine occurrences of the checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/radeon/atom.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atom.c 
b/drivers/gpu/drm/radeon/atom.c
index 11a1940bb26d..93acb0e42bd6 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -68,8 +68,8 @@ typedef struct {
  } atom_exec_context;

  int atom_debug = 0;
-static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t * params);
-int atom_execute_table(struct atom_context *ctx, int index, uint32_t * 
params);
+static int atom_execute_table_locked(struct atom_context *ctx, int 
index, uint32_t *params);
+int atom_execute_table(struct atom_context *ctx, int index, uint32_t 
*params);

  static uint32_t atom_arg_mask[8] = {
  	0xFFFFFFFF, 0x0000FFFF, 0x00FFFF00, 0xFFFF0000,

RE: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

[SHANMUGAM, SRINIVASAN]

[Public]

Reviewed-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of shijie001@208suo.com
Sent: Friday, July 14, 2023 1:36 PM
To: Deucher, Alexander <Alexander.Deucher@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; airlied@gmail.com; daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_audio.c
b/drivers/gpu/drm/radeon/radeon_audio.c
index d6ccaf24ee0c..a010bc2c155c 100644
--- a/drivers/gpu/drm/radeon/radeon_audio.c
+++ b/drivers/gpu/drm/radeon/radeon_audio.c
@@ -35,15 +35,14 @@

  void dce6_audio_enable(struct radeon_device *rdev, struct r600_audio_pin *pin,
          u8 enable_mask);
-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev); -struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
  static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);
  static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);

-static const u32 pin_offsets[7] =
-{
+static const u32 pin_offsets[7] = {
      (0x5e00 - 0x5e00),
      (0x5e18 - 0x5e00),
      (0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct
drm_encoder *encoder,
          radeon_encoder->audio->write_latency_fields(encoder, connector, mode);
  }

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder
*encoder)
+struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder
*encoder)
  {
      struct radeon_device *rdev = encoder->dev->dev_private;
      struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder); @@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int clock, int *CTS, int *N, int freq
          *N, *CTS, freq);
  }

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int
clock)
+static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int
clock)
  {
      static struct radeon_hdmi_acr res;
      u8 i;

[PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

[shijie001]

Fix five occurrences of the checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
ERROR: that open brace { should be on the previous line

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  drivers/gpu/drm/radeon/radeon_audio.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_audio.c 
b/drivers/gpu/drm/radeon/radeon_audio.c
index d6ccaf24ee0c..a010bc2c155c 100644
--- a/drivers/gpu/drm/radeon/radeon_audio.c
+++ b/drivers/gpu/drm/radeon/radeon_audio.c
@@ -35,15 +35,14 @@

  void dce6_audio_enable(struct radeon_device *rdev, struct 
r600_audio_pin *pin,
          u8 enable_mask);
-struct r600_audio_pin* r600_audio_get_pin(struct radeon_device *rdev);
-struct r600_audio_pin* dce6_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *r600_audio_get_pin(struct radeon_device *rdev);
+struct r600_audio_pin *dce6_audio_get_pin(struct radeon_device *rdev);
  static void radeon_audio_hdmi_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);
  static void radeon_audio_dp_mode_set(struct drm_encoder *encoder,
      struct drm_display_mode *mode);

-static const u32 pin_offsets[7] =
-{
+static const u32 pin_offsets[7] = {
      (0x5e00 - 0x5e00),
      (0x5e18 - 0x5e00),
      (0x5e30 - 0x5e00),
@@ -359,7 +358,7 @@ static void radeon_audio_write_latency_fields(struct 
drm_encoder *encoder,
          radeon_encoder->audio->write_latency_fields(encoder, connector, 
mode);
  }

-struct r600_audio_pin* radeon_audio_get_pin(struct drm_encoder 
*encoder)
+struct r600_audio_pin *radeon_audio_get_pin(struct drm_encoder 
*encoder)
  {
      struct radeon_device *rdev = encoder->dev->dev_private;
      struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
@@ -526,7 +525,7 @@ static void radeon_audio_calc_cts(unsigned int 
clock, int *CTS, int *N, int freq
          *N, *CTS, freq);
  }

-static const struct radeon_hdmi_acr* radeon_audio_acr(unsigned int 
clock)
+static const struct radeon_hdmi_acr *radeon_audio_acr(unsigned int 
clock)
  {
      static struct radeon_hdmi_acr res;
      u8 i;