mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul Menage" <menage@google.com>
To: "Patrick McHardy" <kaber@trash.net>
Cc: "Ranjit Manomohan" <ranjitm@google.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	lizf@cn.fujitsu.com
Subject: Re: [PATCH] Traffic control cgroups subsystem
Date: Tue, 22 Jul 2008 08:14:16 -0400	[thread overview]
Message-ID: <6599ad830807220514m5afea0fcsb99bf2e95f401c36@mail.gmail.com> (raw)
In-Reply-To: <4885B7DD.7070507@trash.net>

On Tue, Jul 22, 2008 at 6:35 AM, Patrick McHardy <kaber@trash.net> wrote:
>
> Does this really have to be a new skb member? You could
> simply use skb->sk->sk_cgroup_classid directly, or if
> that doesn't work, maybe skb->priority.
>

We were actually using skb->priority in our internal version of this
patch. I suggested that the separate cgroup_classid field be added
since it might be considered an abuse of skb->priority and would
interfere with existing users of that. If that's not an issue then
reusing skb->priority is certainly possible.

Regarding skb->sk->sk_cgroup_classid, is it always the case that the
original sk is still available when we're making traffic control
decisions? I'd thought that there were cases (e.g. cloning skbs in the
TCP retransmit path) where the pointer to the original sk is lost.

Paul

  reply	other threads:[~2008-07-22 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  4:08 Ranjit Manomohan
2008-07-22 10:35 ` Patrick McHardy
2008-07-22 12:14   ` Paul Menage [this message]
2008-07-22 12:48     ` Patrick McHardy
2008-07-22 12:56       ` Paul Menage
2008-07-22 17:44 Ranjit Manomohan
2008-07-23 22:05 ` Andrew Morton
2008-07-23 22:34   ` Patrick McHardy
2008-07-23 23:54     ` Ranjit Manomohan
2008-07-24  0:17       ` Patrick McHardy
2008-07-24 23:45 ` Thomas Graf
2008-07-25  1:16   ` Ranjit Manomohan
2008-07-25  9:29     ` Thomas Graf
2008-07-25  1:18   ` Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6599ad830807220514m5afea0fcsb99bf2e95f401c36@mail.gmail.com \
    --to=menage@google.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=ranjitm@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome