From: "Paul Menage" <menage@google.com>
To: "Patrick McHardy" <kaber@trash.net>
Cc: "Ranjit Manomohan" <ranjitm@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lizf@cn.fujitsu.com
Subject: Re: [PATCH] Traffic control cgroups subsystem
Date: Tue, 22 Jul 2008 08:56:04 -0400 [thread overview]
Message-ID: <6599ad830807220556i3c2afc77j2e68d7179830b3ff@mail.gmail.com> (raw)
In-Reply-To: <4885D72A.1060106@trash.net>
On Tue, Jul 22, 2008 at 8:48 AM, Patrick McHardy <kaber@trash.net> wrote:
>
> Using skb->priority for classification would be fine, but it would
> probably interfere with the default initialization to sk->sk_priority.
Well internally we just overloaded sk->sk_priority to be the classid,
and let skb->priority be inherited from that.
>
>> Regarding skb->sk->sk_cgroup_classid, is it always the case that the
>> original sk is still available when we're making traffic control
>> decisions? I'd thought that there were cases (e.g. cloning skbs in the
>> TCP retransmit path) where the pointer to the original sk is lost.
>
> After cloning, TCP sets the owner of the skb to the socket, so
> that should work fine.
>
OK, so maybe we don't need a per-skb field after all.
Paul
next prev parent reply other threads:[~2008-07-22 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 4:08 Ranjit Manomohan
2008-07-22 10:35 ` Patrick McHardy
2008-07-22 12:14 ` Paul Menage
2008-07-22 12:48 ` Patrick McHardy
2008-07-22 12:56 ` Paul Menage [this message]
2008-07-22 17:44 Ranjit Manomohan
2008-07-23 22:05 ` Andrew Morton
2008-07-23 22:34 ` Patrick McHardy
2008-07-23 23:54 ` Ranjit Manomohan
2008-07-24 0:17 ` Patrick McHardy
2008-07-24 23:45 ` Thomas Graf
2008-07-25 1:16 ` Ranjit Manomohan
2008-07-25 9:29 ` Thomas Graf
2008-07-25 1:18 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830807220556i3c2afc77j2e68d7179830b3ff@mail.gmail.com \
--to=menage@google.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=ranjitm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®