* [PATCH] use hierarchy mutex in creation failure path
@ 2009-01-16 3:17 KAMEZAWA Hiroyuki
2009-01-16 4:34 ` Paul Menage
0 siblings, 1 reply; 2+ messages in thread
From: KAMEZAWA Hiroyuki @ 2009-01-16 3:17 UTC (permalink / raw)
To: linux-kernel; +Cc: menage, lizf, containers, akpm
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Now, cgrp->sibling is handled under hierarchy mutex.
error route should do so, too.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
kernel/cgroup.c | 2 ++
1 file changed, 2 insertions(+)
Index: mmotm-2.6.29-Jan14/kernel/cgroup.c
===================================================================
--- mmotm-2.6.29-Jan14.orig/kernel/cgroup.c
+++ mmotm-2.6.29-Jan14/kernel/cgroup.c
@@ -2434,7 +2434,9 @@ static long cgroup_create(struct cgroup
err_remove:
+ cgroup_lock_hierarchy(root);
list_del(&cgrp->sibling);
+ cgroup_unlock_hierarchy(root);
root->number_of_cgroups--;
err_destroy:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] use hierarchy mutex in creation failure path
2009-01-16 3:17 [PATCH] use hierarchy mutex in creation failure path KAMEZAWA Hiroyuki
@ 2009-01-16 4:34 ` Paul Menage
0 siblings, 0 replies; 2+ messages in thread
From: Paul Menage @ 2009-01-16 4:34 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: linux-kernel, lizf, containers, akpm
On Thu, Jan 15, 2009 at 7:17 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, cgrp->sibling is handled under hierarchy mutex.
> error route should do so, too.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by Paul Menage <menage@google.com>
Good catch, thanks.
Paul
>
> ---
> kernel/cgroup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: mmotm-2.6.29-Jan14/kernel/cgroup.c
> ===================================================================
> --- mmotm-2.6.29-Jan14.orig/kernel/cgroup.c
> +++ mmotm-2.6.29-Jan14/kernel/cgroup.c
> @@ -2434,7 +2434,9 @@ static long cgroup_create(struct cgroup
>
> err_remove:
>
> + cgroup_lock_hierarchy(root);
> list_del(&cgrp->sibling);
> + cgroup_unlock_hierarchy(root);
> root->number_of_cgroups--;
>
> err_destroy:
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-16 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-16 3:17 [PATCH] use hierarchy mutex in creation failure path KAMEZAWA Hiroyuki
2009-01-16 4:34 ` Paul Menage
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®