[PATCH net 2/2] tun: add missing rx stats accounting in tun_xdp_act

[PATCH net 2/2] tun: add missing rx stats accounting in tun_xdp_act

[Yunjian Wang]

The TUN can be used as vhost-net backend, and it is necessary to
count the packets transmitted from TUN to vhost-net/virtio-net.
However, there are some places in the receive path that were not
taken into account when using XDP. It would be beneficial to also
include new accounting for successfully received bytes using
dev_sw_netstats_rx_add.

Fixes: 761876c857cb ("tap: XDP support")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/tun.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 237fef557ba5..4a4f8c8e79fa 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1634,6 +1634,7 @@ static int tun_xdp_act(struct tun_struct *tun, struct bpf_prog *xdp_prog,
 			dev_core_stats_rx_dropped_inc(tun->dev);
 			return err;
 		}
+		dev_sw_netstats_rx_add(tun->dev, xdp->data_end - xdp->data);
 		break;
 	case XDP_TX:
 		err = tun_xdp_tx(tun->dev, xdp);
@@ -1641,6 +1642,7 @@ static int tun_xdp_act(struct tun_struct *tun, struct bpf_prog *xdp_prog,
 			dev_core_stats_rx_dropped_inc(tun->dev);
 			return err;
 		}
+		dev_sw_netstats_rx_add(tun->dev, xdp->data_end - xdp->data);
 		break;
 	case XDP_PASS:
 		break;
-- 
2.41.0

Re: [PATCH net 2/2] tun: add missing rx stats accounting in tun_xdp_act

[Willem de Bruijn]

Yunjian Wang wrote:
> The TUN can be used as vhost-net backend, and it is necessary to
> count the packets transmitted from TUN to vhost-net/virtio-net.
> However, there are some places in the receive path that were not
> taken into account when using XDP. It would be beneficial to also
> include new accounting for successfully received bytes using
> dev_sw_netstats_rx_add.
> 
> Fixes: 761876c857cb ("tap: XDP support")
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net 2/2] tun: add missing rx stats accounting in tun_xdp_act

[Jason Wang]

On Fri, Jan 19, 2024 at 6:23 PM Yunjian Wang <wangyunjian@huawei.com> wrote:
>
> The TUN can be used as vhost-net backend, and it is necessary to
> count the packets transmitted from TUN to vhost-net/virtio-net.
> However, there are some places in the receive path that were not
> taken into account when using XDP. It would be beneficial to also
> include new accounting for successfully received bytes using
> dev_sw_netstats_rx_add.
>
> Fixes: 761876c857cb ("tap: XDP support")
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks