mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: xiujianfeng <xiujianfeng@huawei.com>
To: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <rostedt@goodmis.org>,
	<mingo@redhat.com>
Subject: Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs
Date: Tue, 6 Sep 2022 22:21:24 +0800	[thread overview]
Message-ID: <65bb173d-1a36-283e-4e20-4bbbcac616c6@huawei.com> (raw)
In-Reply-To: <3f8c0e42-07dc-4349-5021-bcb75e640094@kernel.org>

Hi,

在 2022/9/6 21:43, Daniel Bristot de Oliveira 写道:
> 
> Hi Xiu
> On 9/6/22 13:18, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Regarding the Subject, this patch is not -next. I would suggest only using -next
> when you are fixing something in the linux-next (which is not the case here).
> 
> You can also fix this for the printk reactor. Do you mind re-sending this patch
> with including the printk reactor?

No problem, V2 already sent.

> 
> If you found it using an automatic tool, please add information to the patch.
> Also, try to figure out why it pointed to the panic reactor but did not point to
> printk.

Thanks, I found it by review not tools.

> 
> Add to v2:
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> 
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> 
> Thanks
> -- Daniel
> .
> 

      reply	other threads:[~2022-09-06 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 11:18 Xiu Jianfeng
2022-09-06 13:43 ` Daniel Bristot de Oliveira
2022-09-06 14:21   ` xiujianfeng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65bb173d-1a36-283e-4e20-4bbbcac616c6@huawei.com \
    --to=xiujianfeng@huawei.com \
    --cc=bristot@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®